Add option to connect with disabled_algorithms #149
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@lukas-bednar Hey, can you please review this PR and see what needs to be changed? |
myakove
suggested changes
Jan 25, 2022
myakove
suggested changes
Jan 27, 2022
|
@lukas-bednar moved disabled_algorithms to RemoteExecutorFactoryso it will be used the same way as use_pkey. |
|
This solution looks good to me! |
myakove
suggested changes
Feb 9, 2022
myakove
approved these changes
Feb 9, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This add an option to use disabled_algorithms parameter on SSH connect
Starting paramiko 2.8.2 old openSSH versions dont support some algorithms, this causes the connetion to fail as mentioned in this paramiko issue: paramiko/paramiko#1961
A work around was suggested to use the disabled_algorithms parameter, and it fixes the issues.