Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use 3.3 instead of ruby for ruby versions #231

Closed
wants to merge 1 commit into from

Conversation

m-nakamura145
Copy link
Contributor

The 'ruby' version currently refers to version 3.3.x, but when the new 3.4.0 is released, our current setup will stop testing against 3.3.x.

Therefore, I suggest we explicitly specify version 3.3 and, upon the release of 3.4.0, add and test against version 3.4 as well.

ref: #225 (comment)

@rgrove
Copy link
Owner

rgrove commented Jan 12, 2024

Thanks, but the reason for including ruby in the test matrix is to ensure that we always test against the latest release, even if we forget to update the matrix. We can add 3.3 to the matrix when 3.4 is released, which likely won't be soon given that 3.3.0 only came out a few weeks ago.

@rgrove rgrove closed this Jan 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants