Update to Nokogiri v1.12 #211
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Nokogiri v1.12 merged Nokogumbo code https://github.com/sparklemotion/nokogiri/releases/tag/v1.12.0 Therefore, Nokogumbo is not required as a dependency anymore. If tests are run with latest Nokogiri deprecation note is printed: ``` NOTE: nokogumbo: Using Nokogiri::HTML5 provided by Nokogiri. See sparklemotion/nokogiri#2205 for more information. ```
|
hello, whats the supported nokogiri(nokogumbo merged) version for Ruby 2.3.0 ? |
|
Hey @v29neil. Nokogiri 1.12.0 requires Ruby 2.5.0 or higher. I'm going to lock this conversation because old PRs aren't the best place to ask questions, but if you have more questions feel free to start a discussion. |
Repository owner
locked as resolved and limited conversation to collaborators
Nov 25, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Nokogiri v1.12 merged Nokogumbo code https://github.com/sparklemotion/nokogiri/releases/tag/v1.12.0
Therefore, Nokogumbo is not required as a dependency anymore.
If tests are run with latest Nokogiri, note about deprecation is printed: