Skip to content

Commit

Permalink
ci(pipelines): update pipelines, storybook is broken
Browse files Browse the repository at this point in the history
- [x] make storybook build optional, it needs patching;
see
storybookjs/storybook#16977;
  • Loading branch information
rfprod committed Dec 12, 2021
1 parent 015cdd5 commit 7ec2616
Show file tree
Hide file tree
Showing 8 changed files with 10 additions and 10 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/docker.yml
Expand Up @@ -81,7 +81,7 @@ jobs:
run: yarn workspace:integrity-check

- name: Install project dependencies
run: yarn install --frozen-lockfile
run: yarn install:ci

- name: Unit test all (with code coverage)
run: |
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/e2e-test.yml
Expand Up @@ -40,7 +40,7 @@ jobs:
run: echo fs.inotify.max_user_watches=524288 | sudo tee -a /etc/sysctl.conf && sudo sysctl -p

- name: Install project dependencies
run: yarn install --frozen-lockfile
run: yarn install:ci

- name: Install Cypress
run: npx cypress install
Expand Down
6 changes: 4 additions & 2 deletions .github/workflows/pr-validation.yml
Expand Up @@ -117,7 +117,7 @@ jobs:

- name: Install project dependencies
if: steps.changes.outputs.nx == 'true'
run: yarn install --frozen-lockfile
run: yarn install:ci

- name: Lint affected
if: steps.changes.outputs.nx == 'true'
Expand All @@ -133,4 +133,6 @@ jobs:

- name: Build storybook
if: steps.changes.outputs.nx == 'true'
run: npx nx run documentation:build-storybook
run: |
echo "Broken. Update the package when it's patched. See https://github.com/storybookjs/storybook/issues/16977"
npx nx run documentation:build-storybook || true
2 changes: 1 addition & 1 deletion .github/workflows/trunk-on-push.yml
Expand Up @@ -120,7 +120,7 @@ jobs:

- name: Install project dependencies
if: steps.changes.outputs.nx == 'true'
run: yarn install --frozen-lockfile
run: yarn install:ci

- name: Lint all
if: steps.changes.outputs.nx == 'true'
Expand Down
3 changes: 0 additions & 3 deletions .storybook/main.js
Expand Up @@ -31,9 +31,6 @@ module.exports = {
],
stories: [],
webpackFinal: async (config) => {
// for backwards compatibility call the `rootWebpackConfig`
// this can be removed once that one is migrated fully to
// use the `webpackFinal` property in the `main.js` file
const tsPaths = new TsconfigPathsPlugin({
configFile: './tsconfig.base.json',
});
Expand Down
2 changes: 1 addition & 1 deletion .storybook/tsconfig.json
@@ -1,5 +1,5 @@
{
"exclude": ["../**/*.spec.ts", "../**/*.mock.ts"],
"extends": "../tsconfig.base.json",
"include": ["../libs/client-components/src/**/*.ts", "../libs/client-diagnostics/src/**/*.ts"]
"include": ["../libs/client-components/src/lib/**/*.ts", "../libs/client-diagnostics/src/lib/**/*.ts"]
}
2 changes: 1 addition & 1 deletion apps/documentation/.storybook/tsconfig.json
@@ -1,5 +1,5 @@
{
"extends": "../tsconfig.json",
"exclude": ["../**/*.spec.ts"],
"include": ["../src/**/*"]
"include": ["../../../libs/client-components/src/lib/**/*.stories.ts", "../../../libs/client-diagnostics/src/lib/**/*.stories..ts"]
}
1 change: 1 addition & 0 deletions package.json
Expand Up @@ -58,6 +58,7 @@
"postinstall": "husky install && npx sort-package-json && yarn ngcc && node ./decorate-angular-cli.js",
"install:all:linux": "bash ./tools/shell/install.sh all",
"install:all:osx": "bash ./tools/shell/install.sh all osx",
"install:ci": "yarn install --frozen-lockfile",
"install:global": "bash ./tools/shell/install.sh global",
"install:project": "bash tools/shell/install.sh project",
"install:proto:linux": "bash ./tools/shell/install.sh proto",
Expand Down

0 comments on commit 7ec2616

Please sign in to comment.