Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Disable the "reported by reviewdog 馃惗" Prefix in Review Messages #1667

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from
Draft

feat: Disable the "reported by reviewdog 馃惗" Prefix in Review Messages #1667

wants to merge 2 commits into from

Conversation

Okabe-Junya
Copy link

@Okabe-Junya Okabe-Junya commented Feb 9, 2024 •
edited

ref. #1662

  • Updated Unreleased section in CHANGELOG or it's not notable changes.

Change List

  • delete: the prefix "reported by reviewdog 馃惗" whenever reviewdog comment
  • update: README

@Okabe-Junya Okabe-Junya mentioned this pull request Feb 9, 2024
Open
haya14busa
haya14busa requested changes Feb 9, 2024
View reviewed changes
Copy link
Member

@haya14busa haya14busa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I do not plan to disable it without any config at least.

@Okabe-Junya
Copy link
Author

Thank you :)

I apologize for making such a change in the PR. I would like to modify it so that it can be disabled using the appropriate flags (e.g., disable-prefix)

@Okabe-Junya Okabe-Junya marked this pull request as draft February 9, 2024 16:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@haya14busa haya14busa haya14busa requested changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Okabe-Junya @haya14busa