Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix fail_on_error input #77

Merged
merged 1 commit into from May 14, 2021
Merged

fix fail_on_error input #77

merged 1 commit into from May 14, 2021

Conversation

Doarakko
Copy link
Member

Fixed it.
#64

When fail_on_error is true and golangci-lint is failed, job is not failed.

reproduce

  • reviewdog.yml
name: reviewdog
on: [pull_request]
jobs:
  golangci-lint:
    name: runner / golangci-lint
    runs-on: ubuntu-latest
    steps:
      - name: Check out code into the Go module directory
        uses: actions/checkout@v2

      # optionally use a specific version of Go rather than the default one
      - name: Set up Go
        uses: actions/setup-go@v2
        with:
          go-version: "1.16"

      - name: golangci-lint
        uses: reviewdog/action-golangci-lint@v1.20.0
        with:
          workdir: testdata/
          github_token: ${{ github.token }}
          reporter: "github-pr-review"
          fail_on_error: true

If you would like, I create an issue that lists other repositories that need to fix, and I will fix them one by one.
https://github.com/reviewdog/reviewdog#public-reviewdog-github-actions

@haya14busa haya14busa merged commit c02ba01 into reviewdog:master May 14, 2021
@haya14busa
Copy link
Member

Thanks!

If you would like, I create an issue that lists other repositories that need to fix, and I will fix them one by one.

That would be great!

@review-dog
Copy link
Member

Hi, @Doarakko! We merged your PR to reviewdog! 🐶
Thank you for your contribution! ✨

We just invited you to join the @reviewdog organization on GitHub.
Accept the invite by visiting https://github.com/orgs/reviewdog/invitation.
By joining the team, you'll be a part of reviewdog community and can help the maintainance of reviewdog.

Thanks again!

@github-actions
Copy link
Contributor

🚀 [bumpr] Bumped! New version:v1.21.1 Changes:v1.21.0...v1.21.1

@Doarakko
Copy link
Member Author

Thank you for your review and invitation!

I have created an issue and would like to fix it.
reviewdog/reviewdog#949

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants