Failed linter on GitHub Actions run does not cause check to fail when fail_on_error is true

[Doarakko]

Many repositories need to fix, so please help if you like.

If you could help, it would be helpful if you could comment before starting the work not to overlapping.

Fix example

Run exit command after lint.

echo '::group:: Running golangci-lint with reviewdog 🐶 ...'
golangci-lint run --out-format line-number ${INPUT_GOLANGCI_LINT_FLAGS} \
  | reviewdog -f=golangci-lint \
      -name="${INPUT_TOOL_NAME}" \
      -reporter="${INPUT_REPORTER:-github-pr-check}" \
      -filter-mode="${INPUT_FILTER_MODE:-added}" \
      -fail-on-error="${INPUT_FAIL_ON_ERROR:-false}" \
      -level="${INPUT_LEVEL}" \
      ${INPUT_REVIEWDOG_FLAGS}
exit_code=$?
echo '::endgroup::'

exit $exit_code

reviewdog/action-golangci-lint#77

Todo

I checked the ones that are runnning exit command.

If fail_on_error is not exist in input, please add.

• Template

  • reviewdog/action-template

• Common

  • reviewdog/action-misspell - Run misspell.

• Text (e.g. Markdown)

  • reviewdog/action-alex - Run alex which catches insensitive, inconsiderate writing. (e.g. master/slave)
  • reviewdog/action-languagetool - Run languagetool.
  • tsuyoshicho/action-textlint - Run textlint
  • tsuyoshicho/action-redpen - Run redpen

• Docker

  • reviewdog/action-hadolint - Run hadolint to lint Dockerfile.

• Env

  • dotenv-linter/action-dotenv-linter - Run dotenv-linter to lint .env files.

• Shell script

  • reviewdog/action-shellcheck - Run shellcheck.

• Go

  • reviewdog/action-staticcheck - Run staticcheck.
  • reviewdog/action-golangci-lint - Run golangci-lint and supported linters individually by golangci-lint.

• JavaScript

  • reviewdog/action-eslint - Run eslint.

• CSS

  • reviewdog/action-stylelint - Run stylelint.

• Vim script

  • reviewdog/action-vint - Run vint.
  • tsuyoshicho/action-vimlint - Run vim-vimlint

• Terraform

  • reviewdog/action-tflint - Run tflint.

• YAML

  • reviewdog/action-yamllint - Run yamllint.

• Ruby

  • reviewdog/action-brakeman - Run brakeman.
  • reviewdog/action-reek - Run reek.
  • reviewdog/action-rubocop - Run rubocop.
  • vk26/action-fasterer - Run fasterer.
  • SennaLabs/action-standardrb - Run standardrb.

• Python

  • wemake-python-styleguide - Run wemake-python-styleguide
  • tsuyoshicho/action-mypy - Run mypy

• Kotlin

  • ScaCap/action-ktlint - Run ktlint.

• Android Lint

  • dvdandroid/action-android-lint - Run Android Lint

• Ansible

  • reviewdog/action-ansiblelint - Run ansible-lint

ref: https://github.com/reviewdog/reviewdog#public-reviewdog-github-actions

[Doarakko]

Some repositories seem to fail the check successfully without running exit command.

example

• yamllint
  • yamllint Doarakko/reviewdog-playground#16
• staticcheck
  • staticcheck Doarakko/reviewdog-playground#13

I haven't checked all the repositories yet.

I think it is better to run exit command in a unified manner than to think whether it is necessary to run exit command because it can prevent problems like this one.

At least I'm thinking of adding it to the template repository.
https://github.com/reviewdog/action-template

[gitcoinbot]

Issue Status: 1. Open 2. Started 3. Submitted 4. Done

---

This issue now has a funding of 0.001 ETH (2.25 USD @ $2245.09/ETH) attached to it.

• If you would like to work on this issue you can 'start work' on the Gitcoin Issue Details page.
• Want to chip in? Add your own contribution here.
• Questions? Checkout Gitcoin Help or the Gitcoin's Discord
• $2,135,501.20 more funded OSS Work available on the Gitcoin Issue Explorer

[gitcoinbot]

Issue Status: 1. Open 2. Started 3. Submitted 4. Done

---

Work has been started.

These users each claimed they can complete the work by 265 years, 5 months from now.
Please review their action plans below:

1) richcrown619 has started work.

I will to support this project at all cost

Learn more on the Gitcoin Issue Details page.

[gitcoinbot]

Issue Status: 1. Open 2. Started 3. Submitted 4. Done

---

Work for 0.001 ETH has been submitted by:

---

• Learn more on the Gitcoin Issue Details page
• Want to chip in? Add your own contribution here.
• Questions? Checkout Gitcoin Help or the Gitcoin's Discord
• $2,123,922.71 more funded OSS Work available on the Gitcoin Issue Explorer

[hisuwh]

What's the state of this one. I have got es-lint errors and am exceeding --max-warnings and reviewdog/action-eslint is not failing my build.

[Djiit]

Hi there 👋 stylelint seems to have it, but yet the action is not failing when stylelint fails. Any idea? https://github.com/reviewdog/action-stylelint/blob/master/script.sh#L40

[Doarakko]

@Djiit
It worked fine here.
Doarakko/reviewdog-playground#17

Can you share a repository that isn't working properly?