Bump maven-compiler-plugin from 3.9.0 to 3.10.0 #52
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![dependabot[bot]](https://avatars.githubusercontent.com/in/29110?s=60&v=4){kind=small}
Bumps [maven-compiler-plugin](https://github.com/apache/maven-compiler-plugin) from 3.9.0 to 3.10.0. - [Release notes](https://github.com/apache/maven-compiler-plugin/releases) - [Commits](apache/maven-compiler-plugin@maven-compiler-plugin-3.9.0...maven-compiler-plugin-3.10.0) --- updated-dependencies: - dependency-name: org.apache.maven.plugins:maven-compiler-plugin dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com>
|
Package info applies wrong line endings for windows. Its on by default in 3.10.0. Its been fixed but not released yet. Take a look at maven compiler plugin master. Probably only that fix since the release. I know this looked ok elsewhere but was seen outside github. It might not be a problem everywhere.
Sent from my Verizon, Samsung Galaxy smartphone
Get Outlook for Android<https://aka.ms/AAb9ysg>
…________________________________
From: Christopher Tubbs ***@***.***>
Sent: Monday, February 28, 2022 11:27:05 PM
To: revelc/jsdt-core ***@***.***>
Cc: Jeremy Landis ***@***.***>; Mention ***@***.***>
Subject: Re: [revelc/jsdt-core] Bump maven-compiler-plugin from 3.9.0 to 3.10.0 (PR #52)
@ctubbsii approved this pull request.
@hazendaz<https://github.com/hazendaz> You said there was a problem with this version on Windows? The GitHub Actions build doesn't seem to think so. Do you have more details about that?
—
Reply to this email directly, view it on GitHub<#52 (review)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AAHODI3O4UBD36HJXPCKPGDU5RDJTANCNFSM5PS4NRTQ>.
Triage notifications on the go with GitHub Mobile for iOS<https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675> or Android<https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.
You are receiving this because you were mentioned.Message ID: ***@***.***>
|
|
Actual issue. Sorry described it incorrectly.
apache/maven-compiler-plugin@fa80028
Sent from my Verizon, Samsung Galaxy smartphone
Get Outlook for Android<https://aka.ms/AAb9ysg>
…________________________________
From: Jeremy Landis ***@***.***>
Sent: Tuesday, March 1, 2022, 5:22 PM
To: revelc/jsdt-core; revelc/jsdt-core
Cc: Mention
Subject: Re: [revelc/jsdt-core] Bump maven-compiler-plugin from 3.9.0 to 3.10.0 (PR #52)
Package info applies wrong line endings for windows. Its on by default in 3.10.0. Its been fixed but not released yet. Take a look at maven compiler plugin master. Probably only that fix since the release. I know this looked ok elsewhere but was seen outside github. It might not be a problem everywhere.
Sent from my Verizon, Samsung Galaxy smartphone
Get Outlook for Android<https://aka.ms/AAb9ysg>
________________________________
From: Christopher Tubbs ***@***.***>
Sent: Monday, February 28, 2022 11:27:05 PM
To: revelc/jsdt-core ***@***.***>
Cc: Jeremy Landis ***@***.***>; Mention ***@***.***>
Subject: Re: [revelc/jsdt-core] Bump maven-compiler-plugin from 3.9.0 to 3.10.0 (PR #52)
@ctubbsii approved this pull request.
@hazendaz<https://github.com/hazendaz> You said there was a problem with this version on Windows? The GitHub Actions build doesn't seem to think so. Do you have more details about that?
—
Reply to this email directly, view it on GitHub<#52 (review)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AAHODI3O4UBD36HJXPCKPGDU5RDJTANCNFSM5PS4NRTQ>.
Triage notifications on the go with GitHub Mobile for iOS<https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675> or Android<https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.
You are receiving this because you were mentioned.Message ID: ***@***.***>
Sent from my Verizon, Samsung Galaxy smartphone
Get Outlook for Android<https://aka.ms/AAb9ysg>
|
|
From your description, I found apache/maven-compiler-plugin#95 and https://issues.apache.org/jira/browse/MCOMPILER-485 |
ctubbsii
approved these changes
Mar 1, 2022
dependabot
bot
deleted the
dependabot/maven/org.apache.maven.plugins-maven-compiler-plugin-3.10.0
branch
Actually it saves quite a bit of build time by fixing a long standing incremental compilation bug. My macOS build times have dropped from 7.5 minutes to 4.5 minutes; linux from 4 minutes to 3 minutes. Similar 30% reduction on AIX, Solaris, and FreeBSD builds. Other than the bug, it's actually a really good thing. |
That, and the empty javadoc issue, are definitely nice improvements for the situation where it is needed. I just don't think it should be injecting content into the jar by default that the developer didn't write, especially when that hasn't been the behavior for so long, and few will expect it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bumps maven-compiler-plugin from 3.9.0 to 3.10.0.
Release notes
Sourced from maven-compiler-plugin's releases.
Commits
f4239a4[maven-release-plugin] prepare release maven-compiler-plugin-3.10.0fda9729fix typo gtrhhhrhr49a40abuse githubbd72d75back to snapshot again2863d29[maven-release-plugin] prepare release maven-compiler-plugin-3.10.0807d4e5use last release plugin version037670crestore snapshot version07d635a[maven-release-plugin] prepare for next development iterationa0fa151[maven-release-plugin] prepare release maven-compiler-plugin-3.10.0500ade4add more jdk for testing (#93)Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot mergewill merge this PR after your CI passes on it@dependabot squash and mergewill squash and merge this PR after your CI passes on it@dependabot cancel mergewill cancel a previously requested merge and block automerging@dependabot reopenwill reopen this PR if it is closed@dependabot closewill close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)