Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ci] Skip license check during test as shallow clone doesn't have eno… #529

Merged
merged 1 commit into from
Oct 31, 2021
Merged

[ci] Skip license check during test as shallow clone doesn't have eno… #529

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/maven.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,7 @@ jobs:
key: ${{ matrix.os }}-m2-${{ hashFiles('**/pom.xml') }}
restore-keys: ${{ matrix.os }}-m2
- name: Build with Maven
run: mvn -B -V -e "-Dstyle.color=always" verify
run: mvn -B -V -e "-Dstyle.color=always" verify -D"license.skip=true"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's really important that CI check to verify files are properly licensed. There probably wouldn't be errors if we dropped license-maven-plugin-git, since as far as I can tell, that's only used to populate a few optional copyright fields that might be used inside the license header template... but we have no reference to any of those variables in our license header template.

env:
MAVEN_OPTS: -Djansi.force=true