New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump jsoup from 1.13.1 to 1.14.1 #487
Conversation
Bumps [jsoup](https://github.com/jhy/jsoup) from 1.13.1 to 1.14.1. - [Release notes](https://github.com/jhy/jsoup/releases) - [Changelog](https://github.com/jhy/jsoup/blob/master/CHANGES) - [Commits](jhy/jsoup@jsoup-1.13.1...jsoup-1.14.1) --- updated-dependencies: - dependency-name: org.jsoup:jsoup dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com>
needs some work...looks like lots of bug fixes in this release so this will need to be addressed locally after reviewing what is going on. I'll take a look at it. |
Its not properly formatting now. Its messing up section spacing throughout the sample file. Items such as and some lists are not indented and most items now have extra space at end after >. As it appears they already have another in flight fixing many other things, maybe its just worth waiting. There are already issues with the current one, I've seen it completely delete sections at larger scale (one of whish is listed fixed in this set). It sort of feals like the parser needs extra help. Using eclipse to format the sections it fails on does fix the formatting :( |
OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or minor version, let me know by commenting If you change your mind, just re-open this PR and I'll resolve any conflicts on it. |
@ctubbsii I have diagnosed this and its a bug in my opinion in jsoup. A bug in so much that it breaks pretty formatting. They made a deep internal change to limit whitespace at 30 characters. See my diagnostics here jhy/jsoup#1653. I'm hoping they will be willing to allow exposure of that specific value so we can disable it for our case but also allow something a little more flexible than 30 characters. Once I tested that way with our latest master, it worked out really well. There is still one minor bug but just a one liner issue. That itself is acceptable by me temporarily but the other definitely is not. My hope is this will be something they accept and I'll write it for them if needed as we need off their vulnerable version. While doing this, I discovered a number of things wrong in our current code base around jsoup. We still had a bit of that left over from when we moved xml to eclipse way of doing things (xml-formatter). And we had a number of extra property files in test resources not used at all for a few different configurations so I have that all cleaned up a well. If you could, hang off release for eclipse 2021-09 since its not super pressing and I think we can get this done here. Worst case, I'll just release my fork that fixes the issue we have and support it separately (not ideal but only other tradeoff if we end up in that situation). One other thing, the scale I have this at work running, 500+ repos potentially, we are finding the html formatting when javascript is embedded in some cases is getting deleted. Clearly that is jsoup. So even after this there may be more to go but at least I think I'm on the right path on this. Thanks. |
Bumps jsoup from 1.13.1 to 1.14.1.
Release notes
Sourced from jsoup's releases.
Changelog
Sourced from jsoup's changelog.
... (truncated)
Commits
b24f2e4
[maven-release-plugin] prepare release jsoup-1.14.10bd5885
Release prep changelog updatef034561
Code cleanup0a5a7ef
Minor cleanupcedf83c
Cleanup UTF BOM recognition87085a8
Changelog for #14828db724e
resolve abnormal urls in compliance with rfc3986 (#1482)661523f
Changelog for adoption agency fixe45e53c
Complete adoption agency algorithm (#1517)f49f92c
More robust prevention of XML Declaration recursionDependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase
.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebase
will rebase this PR@dependabot recreate
will recreate this PR, overwriting any edits that have been made to it@dependabot merge
will merge this PR after your CI passes on it@dependabot squash and merge
will squash and merge this PR after your CI passes on it@dependabot cancel merge
will cancel a previously requested merge and block automerging@dependabot reopen
will reopen this PR if it is closed@dependabot close
will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot ignore this major version
will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor version
will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependency
will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)