Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed gulp dependency #647 #648

Merged
merged 1 commit into from Mar 31, 2021
Merged

Removed gulp dependency #647 #648

merged 1 commit into from Mar 31, 2021

Conversation

atxryan
Copy link
Member

@atxryan atxryan commented Mar 31, 2021

Type of PR

  • Documentation changes
  • Code changes
  • Test changes
  • CI-CD changes
  • GitHub Template changes

Purpose of PR

There's a dependabot alert on y18n that's caused by gulp-cli dev dependency. This project is not currently using gulp and this has not been patched in the downstream dependencies yet. This PR removes the gulp dependency.

Validation

  • Unit tests updated and ran successfully
  • Update documentation or issue referenced above

Issues Closed or Referenced

@atxryan atxryan self-assigned this Mar 31, 2021
@atxryan atxryan requested review from bartr, a team, gled4er and Natasha-Kohli and removed request for a team March 31, 2021 18:01
@atxryan atxryan added the Security EE Fundamentals label Mar 31, 2021
Copy link
Member

@bartr bartr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm wondering if we shouldn't just zip the content so we avoid these in the future?

@atxryan atxryan merged commit e58909d into main Mar 31, 2021
@atxryan atxryan deleted the atxryan/y18n-vuln branch March 31, 2021 18:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Security EE Fundamentals
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Dependabot alert: y18n vulnerability found in …/ngsa-typescript/package-lock.json
2 participants