Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Option to add Interceptors on Client Level #2076

Closed
wants to merge 28 commits into from

Conversation

fseidl-bauradar
Copy link
Contributor

Description

Added Possibility to add Client wide Interceptors, to check Request and Responses on multiple positions

Purpose

This pull request is a:

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist

  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

@fseidl-bauradar
Copy link
Contributor Author

#2052

According to the last conversation, you don't like the interfaces, so now I removed them and moved all up into a abstract class named Interceptor, which has 4 Methodes which can be overriden.

@stale
Copy link

stale bot commented Jun 18, 2023

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix label Jun 18, 2023
@repo-ranger
Copy link

repo-ranger bot commented Jun 18, 2023

⚠️ This issue has been marked wontfix and will be closed in 3 days

@fseidl-bauradar
Copy link
Contributor Author

fseidl-bauradar commented Jun 19, 2023

No activity by the author at all, waiting for answer from the author.

@stale stale bot removed the wontfix label Jun 19, 2023
@fseidl-bauradar
Copy link
Contributor Author

I don't see how my code could produce this error.

@fseidl-bauradar
Copy link
Contributor Author

But I found out that exceptions thrown inside the Interceptor are not propagated as expected.

OnBeforeRequest was inside a non async Context, so I moved the call out including code before.
OnBeforeDeserialize was inside a non async context and inside a try catch block, because of this I moved them out
OnAfterRequest is inside a catch block, I moved it out.

@fseidl-bauradar
Copy link
Contributor Author

fseidl-bauradar commented Jun 28, 2023

Closed because of correction

New pullrequest #2108

@fseidl-bauradar
Copy link
Contributor Author

fseidl-bauradar commented Jun 28, 2023

Locally all tests but 3 are running successful

grafik

No interaction with Interceptors or any change that would explain this, I thing that this lies in the realm of the EchoHandler.
Additionally, it's important that the test with the unknown host, checks Language specific Exception Text, this can be a problem for people running test on non english machines

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant