Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature: Added Option to add Interceptors #2048

Closed
wants to merge 8 commits into from

Conversation

fseidl-bauradar
Copy link
Contributor

Description

Added Possibility to add Client wide Interceptors, to check Request and Responses on multiple positions

Purpose

This pull request is a:

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist

  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

@alexeyzimarev
Copy link
Member

Looks good. One comment: why interfaces? These are simple functions, would it not be sufficient to use named delegate types instead? Interfaces are high-cost abstraction compared with functions.

@fseidl-bauradar
Copy link
Contributor Author

@dotnet-policy-service agree company="Bauradar"

@fseidl-bauradar
Copy link
Contributor Author

Looks good. One comment: why interfaces? These are simple functions, would it not be sufficient to use named delegate types instead? Interfaces are high-cost abstraction compared with functions.

I just like Interfaces more and additionally thought about future usage, where a Request/Response Pair is handled in both directions

Removed Console.Test which is not inside Repository
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants