Add RestSharp.Serializers.CsvHelper #1912
Merged
+421
−16
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I recently started using RestSharp to create a C# wrapper library for the AlphaVantage financial data REST API. For memory reasons, Alpha Vantage's more data-intensive APIs output only to CSV (not JSON or XML). All its endpoints support CSV responses, so it makes sense to use CSV as the standard data exchange format for the class library I am writing.
As a result, I added CSV serialization support to RestSharp via the robust CsvHelper library. This pull request includes an adapter between RestSharp and CsvHelper that supports both single-line comma-separated records (individual objects) and full CSV tables (collection types inheriting
IEnumerable
).So far, I've added tests and tried to mimic the precedents/conventions set by the other serializer projects, but I'm not sure what documentation needs to be created.
Best,
Ishan Pranav
Purpose
This pull request is a:
Checklist