Skip to content

Add RestSharp.Serializers.CsvHelper #1912

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 20, 2022
Merged

Conversation

ishanpranav
Copy link
Contributor

@ishanpranav ishanpranav commented Aug 20, 2022

Description

I recently started using RestSharp to create a C# wrapper library for the AlphaVantage financial data REST API. For memory reasons, Alpha Vantage's more data-intensive APIs output only to CSV (not JSON or XML). All its endpoints support CSV responses, so it makes sense to use CSV as the standard data exchange format for the class library I am writing.

As a result, I added CSV serialization support to RestSharp via the robust CsvHelper library. This pull request includes an adapter between RestSharp and CsvHelper that supports both single-line comma-separated records (individual objects) and full CSV tables (collection types inheriting IEnumerable).

So far, I've added tests and tried to mimic the precedents/conventions set by the other serializer projects, but I'm not sure what documentation needs to be created.

Best,
Ishan Pranav

Purpose

This pull request is a:

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist

  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

Sorry, something went wrong.

@alexeyzimarev alexeyzimarev merged commit 8b4d3ef into restsharp:dev Sep 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants