Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test BootableJar using Channel Manifest #4059

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

tommaso-borgato
Copy link
Contributor

@tommaso-borgato tommaso-borgato commented Mar 4, 2024

This PR:

  • reintroduces bootable jar tests
  • adds option to run bootable jar tests with a channel manifest

@tommaso-borgato tommaso-borgato requested a review from a team as a code owner March 4, 2024 12:48
@tommaso-borgato tommaso-borgato force-pushed the bootable-jar branch 3 times, most recently from fd074a7 to 53536e0 Compare March 4, 2024 16:36
@liweinan
Copy link
Collaborator

liweinan commented Mar 5, 2024

The test failures seem to be related with the galleon update.

@tommaso-borgato
Copy link
Contributor Author

@jbliznak can you have a look?

@tommaso-borgato tommaso-borgato force-pushed the bootable-jar branch 2 times, most recently from 168a727 to adb1209 Compare March 6, 2024 13:31
@liweinan
Copy link
Collaborator

liweinan commented Mar 6, 2024

I guess after @jamezp comes back he will check this.

@tommaso-borgato tommaso-borgato force-pushed the bootable-jar branch 2 times, most recently from edad308 to 76186c5 Compare March 25, 2024 14:40
@tommaso-borgato tommaso-borgato force-pushed the bootable-jar branch 3 times, most recently from 1157b69 to 23669c6 Compare March 25, 2024 17:39
@tommaso-borgato tommaso-borgato changed the title Bootable jar Test BootableJar using Channel Manifest Mar 25, 2024
@tommaso-borgato
Copy link
Contributor Author

tommaso-borgato commented Apr 15, 2024

just re-base on main and with both main and this branch I get:

$ mvn clean install -DskipTests
...

[ERROR] Failed to execute goal on project resteasy-core-spi: Could not resolve dependencies for project org.jboss.resteasy:resteasy-core-spi:jar:7.0.0.Alpha2-SNAPSHOT: The following artifacts could not be resolved: jakarta.ws.rs:jakarta.ws.rs-api:jar:4.0.0 (absent): jakarta.ws.rs:jakarta.ws.rs-api:jar:4.0.0 was not found in https://repository.jboss.org/nexus/content/groups/public/ during a previous attempt. This failure was cached in the local repository and resolution is not reattempted until the update interval of jboss-public-repository-group has elapsed or updates are forced -> [Help 1]
...

@jamezp
Copy link
Contributor

jamezp commented Apr 19, 2024

We can talk offline about this, but I need to understand the motivation behind this. I've got some opinions on how we test the bootable JAR that I might share alone, but I don't think we do it right :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants