New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Test BootableJar using Channel Manifest #4059
Open
tommaso-borgato
wants to merge
1
commit into
resteasy:main
Choose a base branch
from
tommaso-borgato:bootable-jar
base: main
Could not load branches
Branch not found: {{ refName }}
Could not load tags
Nothing to show
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tommaso-borgato
force-pushed
the
bootable-jar
branch
3 times, most recently
from
March 4, 2024 16:36
fd074a7
to
53536e0
Compare
The test failures seem to be related with the galleon update. |
@jbliznak can you have a look? |
tommaso-borgato
force-pushed
the
bootable-jar
branch
2 times, most recently
from
March 6, 2024 13:31
168a727
to
adb1209
Compare
I guess after @jamezp comes back he will check this. |
tommaso-borgato
force-pushed
the
bootable-jar
branch
2 times, most recently
from
March 25, 2024 14:40
edad308
to
76186c5
Compare
tommaso-borgato
force-pushed
the
bootable-jar
branch
3 times, most recently
from
March 25, 2024 17:39
1157b69
to
23669c6
Compare
tommaso-borgato
force-pushed
the
bootable-jar
branch
from
April 15, 2024 08:37
23669c6
to
5835899
Compare
just re-base on main and with both main and this branch I get:
|
We can talk offline about this, but I need to understand the motivation behind this. I've got some opinions on how we test the bootable JAR that I might share alone, but I don't think we do it right :) |
tommaso-borgato
force-pushed
the
bootable-jar
branch
from
May 7, 2024 06:57
5835899
to
c50802e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR: