Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use new builtin gha docker cache type #492

Merged
merged 1 commit into from Jun 8, 2023
Merged

Use new builtin gha docker cache type #492

merged 1 commit into from Jun 8, 2023

Conversation

jackkleeman
Copy link
Contributor

With this cache type, we don't need to manually manage the cache.

https://docs.docker.com/build/cache/backends/gha/

This is effectively the fix for docker/build-push-action#252

With this cache type, we don't need to manually manage the cache.

https://docs.docker.com/build/cache/backends/gha/
Copy link
Contributor

@tillrohrmann tillrohrmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice fix. +1 for merging. Please check once this PR is merged that the cache is used (we don't always see the very long docker build times).

@jackkleeman jackkleeman merged commit a73b7ad into restatedev:main Jun 8, 2023
1 check passed
@jackkleeman jackkleeman deleted the improve-docker-cache branch June 8, 2023 16:26
@jackkleeman
Copy link
Contributor Author

Confirmed working @tillrohrmann

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants