Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replaced deprecated HttpMethod.resolve (#1760) #1778

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

felhag
Copy link

@felhag felhag commented Mar 28, 2024

No description provided.

@d0vi
Copy link

d0vi commented Apr 1, 2024

Duplicate of #1767.

@felhag
Copy link
Author

felhag commented Apr 2, 2024

@d0vi , it's not, it's a different file. Kinda looks you tried to update your PR yesterday (which is fine I guess) but it still only contains MockMvcRequestSenderImpl and not WebTestClientRequestSenderImpl.

@d0vi
Copy link

d0vi commented Apr 9, 2024

@d0vi , it's not, it's a different file. Kinda looks you tried to update your PR yesterday (which is fine I guess) but it still only contains MockMvcRequestSenderImpl and not WebTestClientRequestSenderImpl.

Yeah, I updated the commit message adding the issue my commit is meant to close.
After looking at the files we are fixing, it looks like both PRs are complementary! 👌🏻

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants