redis gem has sort of deprecated redis.pipelined

[danlo]

Greetings,

The redis gem is now deprecating the usage of redis.pipelined w/o a block being passed to it

Here is the warning: from this line of code:
https://github.com/redis/redis-rb/blob/master/lib/redis/pipeline.rb#L56

Pipelining commands on a Redis instance is deprecated and will be removed in Redis 5.0.0.

redis.pipelined do
  redis.get("key")
end

should be replaced by

redis.pipelined do |pipeline|
  pipeline.get("key")
end

(called from .../redis-namespace-1.8.2/lib/redis/namespace.rb:530:in `namespaced_block'}

The resque code has the following usages of pipelined:

lib/resque.rb:    sizes = redis.pipelined do
lib/resque.rb:    samples = redis.pipelined do
lib/resque/data_store.rb:        @redis.pipelined do
... (several more)...

Thank you!

-daniel

I would try and fix this as it seams simple, however, I'm not confident in my ruby multithreading skills to attempt to create a fix that would work for everyone. (Sorry!)

[jrochkind]

This isn't "sort of", this is deprecated, right?

These all over my logs are kind of annoying!

It looks like there's already an open PR. Are there any active maintainers who might want to assist on this? @iloveitaly ?

[matthieubrau]

Hello,
There is a PR but nobody to merge it ?
#1796

[jrochkind]

Note for anyone else arriving here annoyed at the deprecation notices, @morenocarullo helpfully pointed out you can silence them with:

Redis.silence_deprecations = true 

In an initializer

Of course, resque will be incompatible with a future version of redis gem unless deprecations are fixed! (note that in "will be removed in Redis 5.0.0.", that means future redis gem release 5.0.0, not the redis software itself, which is already on 6.0).

[atruskie]

I think this was covered by #1806

[anacarolinacastro]

Do you have a prediction date for the new gem version release?

[iloveitaly]

@anacarolinacastro not yet! Unfortunately my time is limited to work on this. Sponsoring me would help me allocate more time here :)

[anacarolinacastro]

hi @iloveitaly

I totally understand your situation, our paid work is our priority! I will wait for the release, no problem.

Thanks!

[mishina2228]

@danlo (Cc: @PatrickTulskie, @iloveitaly)
resque v2.3.0 (the latest is v2.4.0), which address this issue, has already been released.
So I believe we can close this issue (like resque/resque-scheduler#745).

[PatrickTulskie]

@mishina2228 thanks!