Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pipelining commands on a Redis instance is deprecated and will be removed in Redis 5.0.0. #745

Closed
seb-sykio opened this issue Apr 6, 2022 · 7 comments

Comments

@seb-sykio
Copy link

seb-sykio commented Apr 6, 2022

I have this deprecation with Resque.remove_delayed

` Pipelining commands on a Redis instance is deprecated and will be removed in Redis 5.0.0.

redis.pipelined do
redis.get("key")
end

should be replaced by

redis.pipelined do |pipeline|
pipeline.get("key")
end

Redis::Namespace.pipelined(&block#Proc) at .rvm/gems/ruby-3.1.1/gems/redis-namespace-1.8.2/lib/redis/namespace.rb:301
Resque::DataStore.method_missing(sym#Symbol, *args#Array, &block#Proc) at .rvm/gems/ruby-3.1.1/gems/resque-2.2.1/lib/resque/data_store.rb:65
Resque::Scheduler::DelayingExtensions.remove_delayed_job(encoded_job#String) at .rvm/gems/ruby-3.1.1/gems/resque-scheduler-4.5.0/lib/resque/scheduler/delaying_extensions.rb:302
Resque::Scheduler::DelayingExtensions.remove_delayed(klass#Class, *args#Array) at .rvm/gems/ruby-3.1.1/gems/resque-scheduler-4.5.0/lib/resque/scheduler/delaying_extensions.rb:150`

@cody-elhard
Copy link

This is already in the master branch

cb3e9f6

@codealchemy
Copy link

It looks like deprecation warnings are still happening in CI on the latest master (though not related to this gem, those warnings are coming from dependencies - see resque/redis-namespace#193 / resque/resque#1794)

@chinyakao
Copy link

chinyakao commented Apr 10, 2022

Hi,
When I was doing scheduler job, it is still happening.
(Even I installl the gem from github master branch)
Could anyone help me figure out?

resque-scheduler: [INFO] 2022-04-10T18:53:00+08:00: queueing SendReminder (send_reminder)
Pipelining commands on a Redis instance is deprecated and will be removed in Redis 5.0.0.

redis.pipelined do
  redis.get("key")
end

should be replaced by

redis.pipelined do |pipeline|
  pipeline.get("key")
end

(called from /Users/rileykao/.rbenv/versions/3.0.2/lib/ruby/gems/3.0.0/gems/redis-namespace-1.8.2/lib/redis/namespace.rb:530:in `namespaced_block'}

@mishina2228
Copy link
Contributor

@chinyakao Now resque/resque#1806 has been merged into master branch,
so I think you could suppress the warnings by using the master resque-scheduler and resque.

I'm looking forward to the release of new versions of both gems.

@chinyakao
Copy link

@mishina2228 Thank you so much!

@mishina2228
Copy link
Contributor

@seb-sykio (Cc: @PatrickTulskie, @iloveitaly)
resque v2.3.0 (the latest is v2.4.0) and resque-scheduler v4.6.0, which address this issue, has already been released.
So I believe we can close this issue.

@PatrickTulskie
Copy link
Contributor

@mishina2228 Got it. Closing this out. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants