-
Notifications
You must be signed in to change notification settings - Fork 191
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update #sadd to #sadd? #207
Conversation
I don't really know why one of the tests is failing. So for now this PR is more of a suggested change. :) |
Looking into master branch, I guess it hangs from time to time, there are a bunch of cancelled jobs for |
@@ -240,22 +240,22 @@ | |||
end | |||
|
|||
it "should properly intersect three sets" do | |||
@namespaced.sadd('foo', 1) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
try
@namespaced.sadd('foo', [1])
@namespaced.sadd?('foo', 1)
@@ -240,22 +240,22 @@ | |||
end | |||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
probably worth adding
Redis.raise_deprecations = true
Hi 👋 Can we get an update on when this might be merged ? The deprecation message is very polluting for loggers like datadog /coralogix & such (which reflects on the monthly cost) |
I'm also wondering if this will actually solve the warning, since I don't have access to the stack-trace now, since I'm enjoying some time off. :) Otherwise it might still show the warning like it also does for this one: #195 |
If I were a maintainer, I would not merge this as is because it removes tests for a feature still used |
Since several gems now already lock our redis version to < 5.0, mainly Sidekiq, I've just ignored the remaining warnings. Also it seems like we don't get this specific warning anymore after upgrading to the latest sidekiq version. |
Redis now gives this deprecation warning: