Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix kwargs delegation for redis 4.2.0 with Ruby 2.8.0-dev #170

Closed
wants to merge 1 commit into from

Conversation

kamipo
Copy link

@kamipo kamipo commented Jun 10, 2020

redis 4.2.0 with Ruby 2.8.0-dev has broken Rails CI.

redis/redis-rb@1e5d0a1
https://buildkite.com/rails/rails/builds/69984#fc71e8e4-bf32-425b-a466-6487d8fa001d/1793-1824

This allows kwargs delegation for redis 4.2.0 client.

I have found #169 after this change has finished.

Because #169 and this have different directions,

  • Test against ruby 2.7 and fix warnings #169: force add kwargs flag (i.e. end users doesn't need to care about the command should be passed kwargs or not),
  • this change here: respect passed arguments (i.e. end users need to care about the command should be passed kwargs or not),

so I'll leave this as another choice.

@rafaelfranca
Copy link
Member

I went with #169. Thank you for the PR.

@kamipo kamipo deleted the fix_kwargs_error branch August 19, 2020 16:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants