added RateLimiter.drainPermissions method #1240
Merged
+120
−10
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RobWin
requested changes
Nov 9, 2020
...elimiter/src/main/java/io/github/resilience4j/ratelimiter/event/RateLimiterOnDrainEvent.java
Outdated
Show resolved
Hide resolved
...elimiter/src/main/java/io/github/resilience4j/ratelimiter/event/RateLimiterOnDrainEvent.java
Outdated
Show resolved
Hide resolved
storozhukBM
requested changes
Nov 14, 2020
...ratelimiter/src/main/java/io/github/resilience4j/ratelimiter/internal/AtomicRateLimiter.java
Show resolved
Hide resolved
|
@RobWin I think you broke the master branch https://travis-ci.org/github/resilience4j/resilience4j/builds/743885837 and now my branch is broken as well after resolving a conflict |
|
Should be fixed now |
|
@RobWin @storozhukBM can we merge this now? |
|
I will do it when I'm back from quarantine |
RobWin
approved these changes
Nov 30, 2020
hexmind
pushed a commit
to hexmind/resilience4j
that referenced
this pull request
Jan 19, 2023
…o RateLimiter (resilience4j#1240) Co-authored-by: Adam Walczak <adam.walczak@ewejsciowki.pl>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First part of #1228