re_ui crate to encapsulate our own egui theme
#476
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emilk
commented
Dec 6, 2022
| @@ -18,6 +18,17 @@ version = "0.1.7" | |||
| source = "registry+https://github.com/rust-lang/crates.io-index" | |||
| checksum = "330223a1aecc308757b9926e9391c9b47f8ef2dbd8aea9df88312aea18c5e8d6" | |||
|
|
|||
| [[package]] | |||
| name = "accesskit" | |||
There was a problem hiding this comment.
It's a bit weird that Cargo pulls this in even though we don't enable the accesskit features of egui and eframe 🤔
emilk
commented
Dec 6, 2022
Wumpf
approved these changes
Dec 6, 2022
| fn main() { | ||
| let native_options = eframe::NativeOptions { | ||
| initial_window_size: Some([1200.0, 800.0].into()), | ||
| follow_system_theme: false, |
There was a problem hiding this comment.
so we're looked to dark theme in this sample? Why do we distinguish in a few places then?
There was a problem hiding this comment.
We are using dark theme everywhere for now. We had light theme support at the start, and I didn't see any reason to remove that support, since we will perhaps want to add it again in the future.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #400
Checklist
CHANGELOG.md(if this is a big enough change to warrant it)