Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle ctrl+c to gracefully shutdown the server(s) #1613

Merged
merged 13 commits into from
Mar 21, 2023
Merged

Handle ctrl+c to gracefully shutdown the server(s) #1613

merged 13 commits into from
Mar 21, 2023

Commits on Mar 20, 2023

  1. Handle ctrl+c to gracefully shutdown the server(s)

    @Wumpf
    Wumpf committed Mar 20, 2023
    Configuration menu
    Copy the full SHA
    6adb7fa View commit details
    Browse the repository at this point in the history

  2. formatting

    @Wumpf
    Wumpf committed Mar 20, 2023
    Configuration menu
    Copy the full SHA
    bd98911 View commit details
    Browse the repository at this point in the history

  3. move setup_ctrl_c_handler to re_web_viewer_server

    @Wumpf
    Wumpf committed Mar 20, 2023
    Configuration menu
    Copy the full SHA
    2efb8d8 View commit details
    Browse the repository at this point in the history

  4. comment fix, use channel for server shutdown in RemoteViewerServer

    @Wumpf
    Wumpf committed Mar 20, 2023
    Configuration menu
    Copy the full SHA
    686f274 View commit details
    Browse the repository at this point in the history

  5. use tokio in re_web_viewer_server/server in order to use same gracefu… 

    …l shutdown mechanism

Had to move setup_ctrl_c_handler back to `rerun` because of this
    @Wumpf
    Wumpf committed Mar 20, 2023
    Configuration menu
    Copy the full SHA
    3cd7aef View commit details
    Browse the repository at this point in the history

  6. don't create tokio runtime if there is already one

    @Wumpf
    Wumpf committed Mar 20, 2023
    Configuration menu
    Copy the full SHA
    e3d2027 View commit details
    Browse the repository at this point in the history

  7. move responsibility for alive tokio runtime outside of web_viewer. Do… 

    …n't create a new runtime if there is one already. Gracefully wait on ctrl+c instead of sleeping for `RerunArgs` entrypoint
    @Wumpf
    Wumpf committed Mar 20, 2023
    Configuration menu
    Copy the full SHA
    078c92d View commit details
    Browse the repository at this point in the history

  8. Fix python serve lacking a tokio runtime

    @Wumpf
    Wumpf committed Mar 20, 2023
    Configuration menu
    Copy the full SHA
    b71d15a View commit details
    Browse the repository at this point in the history

  9. Merge remote-tracking branch 'origin/main' into andreas/fix-crash-on-… 

    …serve-exit
    @Wumpf
    Wumpf committed Mar 20, 2023
    Configuration menu
    Copy the full SHA
    0b6f312 View commit details
    Browse the repository at this point in the history

  10. fix doc test

    @Wumpf
    Wumpf committed Mar 20, 2023
    Configuration menu
    Copy the full SHA
    d295ed9 View commit details
    Browse the repository at this point in the history

Commits on Mar 21, 2023

  1. Fix warnings

    @emilk
    emilk committed Mar 21, 2023
    Configuration menu
    Copy the full SHA
    9a15af3 View commit details
    Browse the repository at this point in the history

  2. improve docstring

    @emilk
    emilk committed Mar 21, 2023
    Configuration menu
    Copy the full SHA
    236a4f0 View commit details
    Browse the repository at this point in the history

  3. don't unwrap, especially in drop

    @emilk
    emilk committed Mar 21, 2023
    Configuration menu
    Copy the full SHA
    96f7556 View commit details
    Browse the repository at this point in the history