Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added secrets to actions to run test example #538

Merged
merged 2 commits into from
Apr 20, 2024
Merged

Conversation

JonathanHuot
Copy link
Contributor

No description provided.

@coveralls
Copy link

coveralls commented Mar 22, 2024

Coverage Status

coverage: 90.097%. remained the same
when pulling 59f3d6a on docs-examples
into 7af9125 on master.

@JonathanHuot
Copy link
Contributor Author

I need to add documentation on "how to add new example", and this will be considered complete. Note that examples are "skipped" if the secrets does not exists (see https://github.com/requests/requests-oauthlib/blob/master/tests/examples/test_native_spa_pkce_auth0.py#L13) .
In this MR, we have all tests passed, so the "optional" tests are not skipped.

@jtroussard
Copy link
Contributor

Will the docs contain guidance on how to load/maintain the secrets?

@JonathanHuot JonathanHuot changed the title WIP: Added secrets to actions to run test example Added secrets to actions to run test example Apr 9, 2024
@JonathanHuot
Copy link
Contributor Author

Hi @jtroussard & al, you can check docs locally but I think it is good for a first revision.
Any comments are welcome.

@JonathanHuot JonathanHuot added this to the 2.0.1 milestone Apr 20, 2024
@JonathanHuot JonathanHuot merged commit 77905a4 into master Apr 20, 2024
7 checks passed
@jtroussard
Copy link
Contributor

@JonathanHuot sorry to revive this one. First off, amazing contribution. Second, my apologies, I must have missed this notification and did not see this PR or request to review. I was only alerted to this once the merged notification hit my dashboard.

After reviewing your native spa example, and the new documentation, I've set out to update some of our other examples. I might have some clarifying questions coming soon. Thanks for this again!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants