Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Support for OAuth Mutual TLS (draft-ietf-oauth-mtls) #389

Merged
merged 4 commits into from Dec 19, 2019

Conversation

danielfett
Copy link

OAuth Mutual TLS is on track to become an IETF standard. It will be used in many high-risk scenarios, including Open Banking (see OpenID FAPI), e-health applications, and e-government applications. This patch adds support for client authentication via MTLS.

@coveralls
Copy link

coveralls commented Nov 29, 2019

Coverage Status

Coverage decreased (-0.03%) to 90.462% when pulling a8f45a7 on danielfett:master into 792f184 on requests:master.

@singingwolfboy
Copy link
Member

This looks like a great start! However, we need an automated test covering this change, and an entry in the HISTORY.rst file.

Let me know if you have any difficulty with writing this test. I think you'll want to mock the requests library, and verify that it's being called with the cert parameter.

@danielfett
Copy link
Author

Added tests and HISTORY.rst entry.

@singingwolfboy
Copy link
Member

Looks great! Thank you! 🎉

@singingwolfboy singingwolfboy merged commit 29ba9af into requests:master Dec 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants