Skip to content

Commit

Permalink
Merge pull request #525 from JWCook/fix-params-positional-arg
Browse files Browse the repository at this point in the history
Fix support for params, data, and json as positional arguments to CachedSession.request()
  • Loading branch information
JWCook committed Feb 13, 2022
2 parents aafc42f + fea0eff commit ebb5f69
Show file tree
Hide file tree
Showing 7 changed files with 75 additions and 53 deletions.
12 changes: 11 additions & 1 deletion .all-contributorsrc
Expand Up @@ -193,7 +193,8 @@
"contributions": [
"bug",
"doc",
"ideas"
"ideas",
"code"
]
},
{
Expand Down Expand Up @@ -734,6 +735,15 @@
"contributions": [
"bug"
]
},
{
"login": "girst",
"name": "girst",
"avatar_url": "https://avatars.githubusercontent.com/u/11820748?v=4",
"profile": "https://gir.st/",
"contributions": [
"bug"
]
}
],
"contributorsPerLine": 7,
Expand Down
1 change: 1 addition & 0 deletions .gitignore
Expand Up @@ -6,6 +6,7 @@
*.egg-info
build/
dist/
downloads/
http_cache/
venv/
.venv
Expand Down
5 changes: 3 additions & 2 deletions CONTRIBUTORS.md
Expand Up @@ -24,7 +24,7 @@ contributions that have helped to improve requests-cache:
<td align="center"><a href="http://davidstosik.github.io/"><img src="https://avatars.githubusercontent.com/u/816901?v=4?s=100" width="100px;" alt=""/><br /><sub><b>David Stosik</b></sub></a><br /><a href="https://github.com/reclosedev/requests-cache/issues?q=author%3Adavidstosik" title="Bug reports">πŸ›</a></td>
<td align="center"><a href="https://github.com/scraperdragon"><img src="https://avatars.githubusercontent.com/u/1957682?v=4?s=100" width="100px;" alt=""/><br /><sub><b>Dragon Dave McKee</b></sub></a><br /><a href="https://github.com/reclosedev/requests-cache/commits?author=scraperdragon" title="Code">πŸ’»</a></td>
<td align="center"><a href="http://edwardbetts.com/"><img src="https://avatars.githubusercontent.com/u/3818?v=4?s=100" width="100px;" alt=""/><br /><sub><b>Edward Betts</b></sub></a><br /><a href="https://github.com/reclosedev/requests-cache/commits?author=EdwardBetts" title="Code">πŸ’»</a> <a href="https://github.com/reclosedev/requests-cache/commits?author=EdwardBetts" title="Documentation">πŸ“–</a></td>
<td align="center"><a href="https://github.com/glensc"><img src="https://avatars.githubusercontent.com/u/199095?v=4?s=100" width="100px;" alt=""/><br /><sub><b>Elan RuusamΓ€e</b></sub></a><br /><a href="https://github.com/reclosedev/requests-cache/issues?q=author%3Aglensc" title="Bug reports">πŸ›</a> <a href="https://github.com/reclosedev/requests-cache/commits?author=glensc" title="Documentation">πŸ“–</a> <a href="#ideas-glensc" title="Ideas, Planning, & Feedback">πŸ€”</a></td>
<td align="center"><a href="https://github.com/glensc"><img src="https://avatars.githubusercontent.com/u/199095?v=4?s=100" width="100px;" alt=""/><br /><sub><b>Elan RuusamΓ€e</b></sub></a><br /><a href="https://github.com/reclosedev/requests-cache/issues?q=author%3Aglensc" title="Bug reports">πŸ›</a> <a href="https://github.com/reclosedev/requests-cache/commits?author=glensc" title="Documentation">πŸ“–</a> <a href="#ideas-glensc" title="Ideas, Planning, & Feedback">πŸ€”</a> <a href="https://github.com/reclosedev/requests-cache/commits?author=glensc" title="Code">πŸ’»</a></td>
</tr>
<tr>
<td align="center"><a href="https://github.com/Querela"><img src="https://avatars.githubusercontent.com/u/1648294?v=4?s=100" width="100px;" alt=""/><br /><sub><b>Erik KΓΆrner</b></sub></a><br /><a href="https://github.com/reclosedev/requests-cache/issues?q=author%3AQuerela" title="Bug reports">πŸ›</a> <a href="#ideas-Querela" title="Ideas, Planning, & Feedback">πŸ€”</a></td>
Expand Down Expand Up @@ -95,10 +95,11 @@ contributions that have helped to improve requests-cache:
<td align="center"><a href="https://github.com/coryairbhb"><img src="https://avatars.githubusercontent.com/u/50755629?v=4?s=100" width="100px;" alt=""/><br /><sub><b>coryairbhb</b></sub></a><br /><a href="https://github.com/reclosedev/requests-cache/issues?q=author%3Acoryairbhb" title="Bug reports">πŸ›</a></td>
<td align="center"><a href="https://github.com/craigls"><img src="https://avatars.githubusercontent.com/u/972350?v=4?s=100" width="100px;" alt=""/><br /><sub><b>craig</b></sub></a><br /><a href="https://github.com/reclosedev/requests-cache/commits?author=craigls" title="Code">πŸ’»</a> <a href="https://github.com/reclosedev/requests-cache/issues?q=author%3Acraigls" title="Bug reports">πŸ›</a></td>
<td align="center"><a href="https://stackoverflow.com/users/86643/denis"><img src="https://avatars.githubusercontent.com/u/1280390?v=4?s=100" width="100px;" alt=""/><br /><sub><b>denis-bz</b></sub></a><br /><a href="https://github.com/reclosedev/requests-cache/issues?q=author%3Adenis-bz" title="Bug reports">πŸ›</a></td>
<td align="center"><a href="https://gir.st/"><img src="https://avatars.githubusercontent.com/u/11820748?v=4?s=100" width="100px;" alt=""/><br /><sub><b>girst</b></sub></a><br /><a href="https://github.com/reclosedev/requests-cache/issues?q=author%3Agirst" title="Bug reports">πŸ›</a></td>
<td align="center"><a href="https://github.com/gorogoroumaru"><img src="https://avatars.githubusercontent.com/u/30716350?v=4?s=100" width="100px;" alt=""/><br /><sub><b>gorogoroumaru</b></sub></a><br /><a href="https://github.com/reclosedev/requests-cache/commits?author=gorogoroumaru" title="Code">πŸ’»</a></td>
<td align="center"><a href="https://github.com/harvey251"><img src="https://avatars.githubusercontent.com/u/33844174?v=4?s=100" width="100px;" alt=""/><br /><sub><b>harvey251</b></sub></a><br /><a href="https://github.com/reclosedev/requests-cache/issues?q=author%3Aharvey251" title="Bug reports">πŸ›</a></td>
</tr>
<tr>
<td align="center"><a href="https://github.com/harvey251"><img src="https://avatars.githubusercontent.com/u/33844174?v=4?s=100" width="100px;" alt=""/><br /><sub><b>harvey251</b></sub></a><br /><a href="https://github.com/reclosedev/requests-cache/issues?q=author%3Aharvey251" title="Bug reports">πŸ›</a></td>
<td align="center"><a href="https://github.com/mbarkhau"><img src="https://avatars.githubusercontent.com/u/446561?v=4?s=100" width="100px;" alt=""/><br /><sub><b>mbarkhau</b></sub></a><br /><a href="https://github.com/reclosedev/requests-cache/commits?author=mbarkhau" title="Code">πŸ’»</a> <a href="https://github.com/reclosedev/requests-cache/commits?author=mbarkhau" title="Tests">⚠️</a> <a href="#infra-mbarkhau" title="Infrastructure (Hosting, Build-Tools, etc)">πŸš‡</a> <a href="https://github.com/reclosedev/requests-cache/issues?q=author%3Ambarkhau" title="Bug reports">πŸ›</a></td>
<td align="center"><a href="https://github.com/shiftinv"><img src="https://avatars.githubusercontent.com/u/8530778?v=4?s=100" width="100px;" alt=""/><br /><sub><b>shiftinv</b></sub></a><br /><a href="https://github.com/reclosedev/requests-cache/commits?author=shiftinv" title="Code">πŸ’»</a> <a href="https://github.com/reclosedev/requests-cache/issues?q=author%3Ashiftinv" title="Bug reports">πŸ›</a></td>
<td align="center"><a href="https://www.witionstheme.com/"><img src="https://avatars.githubusercontent.com/u/55755139?v=4?s=100" width="100px;" alt=""/><br /><sub><b>witionstheme</b></sub></a><br /><a href="https://github.com/reclosedev/requests-cache/issues?q=author%3Awitionstheme" title="Bug reports">πŸ›</a></td>
Expand Down
4 changes: 4 additions & 0 deletions HISTORY.md
@@ -1,5 +1,9 @@
# History

## 0.9.2 (Unreleased)
* Support `params`, `data`, and `json` as positional arguments to `CachedSession.request()` (fixes
regression in `0.9.0`)

## 0.9.1 (2022-01-15)
* Add support for python 3.10.2 and 3.9.10 (regarding resolving `ForwardRef` types during deserialization)
* Add support for key-only request parameters (regarding hashing request data for cache key creation)
Expand Down

0 comments on commit ebb5f69

Please sign in to comment.