Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RQ-1327] fix: relay authorization header in case of cross origin XHR redirects #1432

Merged
merged 4 commits into from Feb 23, 2024

Conversation

nafees87n
Copy link
Contributor

@nafees87n nafees87n commented Feb 19, 2024

Closes issue: #1208

📜 Summary of changes:

XMLHttpRequest builds upon Fetch. It doesn’t define its own network logic. (If we added another API that could set headers it would also end up with this behavior.)

Forwards authorization header in case of cross-origin Requestly XHR redirects

✅ Checklist:

  • Make sure linting and unit tests pass.
  • No install/build warnings introduced.
  • Verified UI in browser.
  • For UI changes, added/updated analytics events (if applicable).
  • For changes in extension's code, manually tested in Chrome and Firefox.
  • For changes in extension's code, both MV2 and MV3 are covered.
  • Added/updated unit tests for this change.
  • Raised pull request to update corresponding documentation (if already exists).

🧪 Test instructions:

🔗 Other references:

@nafees87n nafees87n merged commit c1708cc into master Feb 23, 2024
1 check passed
@nafees87n nafees87n deleted the RQ-1327 branch February 23, 2024 08:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants