Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typo 'securityOptions' => 'secureOptions' #3198

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

scovetta
Copy link

PR Checklist:

(No code was changed; this was a minor typo in the README.)

  • I have run npm test locally and all tests are passing.
  • I have added/updated tests for any new behavior.
  • If this is a significant change, an issue has already been created where the problem / solution was discussed: [N/A, or add link to issue here]

PR Description

I think this is a typo (nodejs/node-v0.x-archive#8608 and elsewhere in the request codebase). Passing in as 'securityOptions' would probably be a no-op, at least from first glance.

I think this is a typo (nodejs/node-v0.x-archive#8608 and elsewhere in the request codebase). Passing in as 'securityOptions' would probably be a no-op, at least from first glance.
@stale
Copy link

stale bot commented Aug 25, 2020

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Aug 25, 2020
@scovetta
Copy link
Author

Could this get merged? It's just a doc update.

@stale stale bot removed the stale label Aug 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant