Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow content-length of 0 (#920) #3084

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Allow content-length of 0 (#920) #3084

wants to merge 1 commit into from

Conversation

pretorh
Copy link

@pretorh pretorh commented Dec 10, 2018

PR Checklist:

  • I have run npm test locally and all tests are passing.
  • I have added/updated tests for any new behavior.
  • If this is a significant change, an issue has already been created where the problem / solution was discussed: [N/A]

PR Description

Change check for if length is set in order to allow passing a 0-length buffer as body. Previously this emited an error. This is to fix #920

@pretorh
Allow content-length of 0 (request#920)
6dcdce7 
fix check for if length is set in order to allow passing a 0-length
buffer as body
@jeremyBanks jeremyBanks mentioned this pull request Dec 14, 2018
Closed
@stephenh
Copy link

FWIW we ran into this as well, would be great to have this merged. Thansk @pretorh !

@ricellis ricellis mentioned this pull request Jan 11, 2019
Closed
@jdmarshall
Copy link

jdmarshall commented Oct 26, 2019 •
edited

Also running into this, and agree with the proposed solution.

@Mikael ? @reconbot ? Somebody?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Up for consideration
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Sending requests with content-length equal to zero raises an error
4 participants
@pretorh @stephenh @jdmarshall @reconbot