Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Failure to set proxy during redirects #2685

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

atti187
Copy link

@atti187 atti187 commented Jun 8, 2017

PR Checklist:

  • I have run npm test locally and all tests are passing.
  • I have added/updated tests for any new behavior.
  • If this is a significant change, an issue has already been created where the problem / solution was discussed: [Failure to set proxy during redirects #2683]

PR Description

This change makes sure that the proxy setting is re-evaluated according to the redirect url

@BYK
Copy link

BYK commented Nov 14, 2017

@mikeal - Anything blocking the merge of this PR? It looks well-written, complete with a test case and merging that would allow us to update the requests version in Yarn and fix a bug instead of having to implement a workaround ourselves.

@stale
Copy link

stale bot commented Nov 23, 2018

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Nov 23, 2018
@stale stale bot removed the stale label Nov 23, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants