Fixed #2614. Content length of the body of the Post request is calcul… #2615
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ated properly when using OAuth 1.0 and 'form' object and transport_method=body
Huachao
approved these changes
Mar 30, 2017
|
So who can merge this, @Huachao ? |
|
@dvishniakov sorry, I am not a collaborator of this project, and just have interest in reviewing your code. I think @FredKSchott have this permission. |
|
@FredKSchott can you advice how to proceed? |
|
@mikeal any ideas how is it possible to make some progress here? Thanks |
|
@simov hi, any ideas how is it possible to make some progress here? Thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ated properly when using OAuth 1.0 and 'form' object and transport_method=body
PR Checklist:
npm testlocally and all tests are passing.PR Description
Fixes #2614 and possibly #2599
Content-length of the body is calculated after OAuth because OAuth can update body if transport_method=body.