Skip to content

Commit

Permalink
Update of hawk and qs to latest version (#2751)
Browse files Browse the repository at this point in the history
  • Loading branch information
@Olivier-Moreau @mikeal
Olivier-Moreau authored and mikeal committed Aug 24, 2017
1 parent 643c43a commit 479143d
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions package.json
View file
Expand Up @@ -35,15 +35,15 @@
"forever-agent": "~0.6.1",
"form-data": "~2.1.1",
"har-validator": "~5.0.2",
"hawk": "~3.1.3",
"hawk": "~6.0.2",
"http-signature": "~1.1.0",
"is-typedarray": "~1.0.0",
"isstream": "~0.1.2",
"json-stringify-safe": "~5.0.1",
"mime-types": "~2.1.7",
"oauth-sign": "~0.8.1",
"performance-now": "^0.2.0",
"qs": "~6.4.0",
"qs": "~6.5.0",
"safe-buffer": "^5.0.1",
"stringstream": "~0.0.4",
"tough-cookie": "~2.3.0",
Expand Down

5 comments on commit 479143d

@sdd
Copy link

@sdd sdd commented on 479143d Sep 21, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change of the hawk dependency version breaks node <v4 compatibility.

/node_modules/request/node_modules/hawk/node_modules/boom/lib/index.js:5
const Hoek = require('hoek');
^^^^^
SyntaxError: Use of const in strict mode.

I can already hear people shouting "unsupported!" but if it ain't broke, don't fix it. Oh well, I guess now I gotta fix it :-)

@Pinny3
Copy link

@Pinny3 Pinny3 commented on 479143d Sep 22, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When is this going to be fixed?

@mikeal
Copy link
Member

@mikeal mikeal commented on 479143d Sep 22, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are two closed issues discussing this.

It won't be fixed because it's not a bug. Required version was updated to v4+ 11 months ago.

@spcags
Copy link

@spcags spcags commented on 479143d Feb 1, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mikeal Could please at least provide a workaround solution to this? Sorry that I need to support the production app with Node 0.10.46. Thanks.

@dobriai
Copy link

@dobriai dobriai commented on 479143d Apr 7, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FWIW, I should add that upgrading to this version of hawk also breaks any code that uses "Create React App", as it does not seem to provide a EC5 module, so Webpack chokes:

$ node scripts/build.js
Creating an optimized production build...
Failed to compile.

Failed to minify the code from this file:

        ./node_modules/hawk/lib/utils.js:77

Read more here: http://bit.ly/2tRViJ9

Here is another, related thread: hapijs/hoek#225

Please sign in to comment.