Add Sphinx 4.0 compatibility, drop EOLed Pythons #17
Conversation
- Correct meta information url, license, and add project_urls
|
I recommend adding |
|
Also, Travis announced to shut down travis-ci.org at the end of May. |
|
@hugovk thank you, added! @jugmac00 thanks for the reminder. I'll start adding GitHub Actions. Someone with permission needs to enable GHA on this repo. What should be the author_email attribute in setup.py? It is currently repoze-dev@lists.repoze.org, and repoze.org is dead. |
The author e-mail field is not required, see python/cpython#17388 |
|
@malthe @MatthewWilkes @mcdonc @tseaver show as developers of the Repoze organization. I assume that they have access to enable GitHub Actions. Anyone else? Maybe PyPI maintainers @wichert or @dataflake? |
@jugmac00 Please could you point me to where they announced it? The banner has said "in several weeks" since 15 Dec 2020, and they initially said they would shut down by the end of 2020. Anyway, definitely agree with migrating to GitHub Actions 🚀 @stevepiercy To enable GHA, I think you just need to have a workflow file merged? |
https://blog.travis-ci.com/2021-05-07-orgshutdown @hugovk Let's spread the word: |
|
I've done the easy things from #16 (comment). That leaves at least these two items to resolve, probably others:
|
|
@hugovk for some reason it is not running on this repo as I would expect, so I added CI to this branch and it has queued the tests on my fork. It seems to be taking a while to start. Anyway, I think maintainers need to do something, such as create a new branch |
There's an "incident" right now, should get cleared in a little white: |
Fix broken links Clean up code-blocks Fix typos
|
Incident resolved, restarted build, and it fails, but now everyone can see what causes the failures. I'll keep slogging through the housecleaning stuff, like this one: |
Looks like my fix made it in Python 3.9+ only, and was not backported. Update |
|
I've restored the I've reached out to @tseaver and @mcdonc in Keybase as well as @mmerickel and @bertjwregeer from Pylons to ask what is the best way forward to ensure that this package is maintained. I've volunteered, but need direction, whether that's being granted maintainer permission here and on PyPI, forking it to another organization, or something else. |
Restore author and author_email in setup.py, even though they are dead Fix README.rst rendering Add MANIFEST.in and related necessary bits
|
Progress! The housecleaning now brings us to a point where the build fails due to what brought up this issue in the first place. |
|
We got a temporary reprieve in sphinx-doc/sphinx#9326 but it will come back in Sphinx 5.0. |
|
See stevepiercy#1 which builds on this PR to get the tests running again. |
Fix compatibility with Sphinx 4 and 5.0b1.
I lack access to do so through the UI, and Travis-ci-org is dead, so this probably won't work.
|
@bertjwregeer @tseaver @mcdonc @mmerickel @malthe @MatthewWilkes @wichert @dataflake this PR is ready for review. Travis-ci.org is dead, and GitHub Actions don't run in this organization yet. Nonetheless tests did pass on my fork. https://github.com/stevepiercy/repoze.sphinx.autointerface/runs/6484737469?check_suite_focus=true |
|
I realize that Python 3.5 is EOL, but is there a specific technical reason why it must be excluded? I'm only saying that because on the Zope side we have promised to support Python 3.5 in conjunction with Zope 4 until Zope 4 is EOL itself. |
|
@dataflake I could try adding 3.5 to the test matrix. Let's see: https://github.com/stevepiercy/repoze.sphinx.autointerface/runs/6485627391?check_suite_focus=true |
|
@dataflake Sphinx 4.0 dropped Python 3.5 support. https://www.sphinx-doc.org/en/master/changes.html#id308 I reverted the restoration of 3.5, and kept 3.10: |
|
@dataflake wrote:
As this library is only needed while creating the documentation. I think in Zope land we can live with the drop of Python 3.5 support. I'd rather like to see progress using a more modern Sphinx version than being stuck on an older one because of an unsupported Python version. |
|
@stevepiercy Never mind then, it's OK to drop 3.5. Thanks for the work! |
|
@dataflake I do not have write access and cannot merge this PR. I've done what I can to push this forward, except fork it and release it as a new package as a last resort. |
|
repoze.shinx.autointerface version 1.0.0 is now on PyPI. |
See #16, #13.
This is a work in progress.