Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump to v16 nodejs #586

Merged
merged 3 commits into from May 20, 2022
Merged

Bump to v16 nodejs #586

merged 3 commits into from May 20, 2022

Conversation

nitrocode
Copy link
Contributor

@nitrocode nitrocode commented May 19, 2022 •
edited

what

  • Bump to v16 nodejs
  • Bump actions to use v3 which defaults to using v16 nodejs

references

@vercel
Copy link

vercel bot commented May 19, 2022

@nitrocode is attempting to deploy a commit to the Probot Team on Vercel.

A member of the Team first needs to authorize it.

@nitrocode nitrocode mentioned this pull request May 19, 2022
Closed
@travi
Copy link
Member

travi commented May 19, 2022

Thanks for this. Would you mind changing the github ci workflow to reference this as well?

@nitrocode
Copy link
Contributor Author

@travi I setup the node github action to read from the .nvmrc file.

travi
travi approved these changes May 20, 2022
View reviewed changes
Copy link
Member

@travi travi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@travi travi merged commit 358f148 into repository-settings:master May 20, 2022
@nitrocode nitrocode deleted the patch-1 branch May 21, 2022 13:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@travi travi travi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@nitrocode @travi