Fix doctrine proxy and UI for organization members #130
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## members #130 +/- ##
==========================================
Coverage 99.83% 99.83%
- Complexity 1094 1095 +1
==========================================
Files 190 190
Lines 3116 3116
==========================================
Hits 3111 3111
Misses 5 5
Continue to review full report at Codecov.
|
akondas
commented
May 4, 2020
| @@ -1,6 +1,8 @@ | |||
| includes: | |||
| - vendor/phpstan/phpstan/conf/bleedingEdge.neon | |||
| parameters: | |||
| excludes_analyse: | |||
| - src/Entity/Organization.php | |||
There was a problem hiding this comment.
I'm not happy with this, but I had to add default null because of doctrine/common#886, so I exclude this file from analysis (I only hope temporarily). Another option is downgrade php ...
karniv00l
approved these changes
May 4, 2020
karniv00l
pushed a commit
that referenced
this pull request
May 4, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.