Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove audio #219

Merged
merged 1 commit into from
May 17, 2024
Merged

remove audio #219

merged 1 commit into from
May 17, 2024

Conversation

ryantm
Copy link
Collaborator

@ryantm ryantm commented May 17, 2024

Why

  • The audio service is not frequently used.
  • The audio service is not core to Replit.
  • Replit still supports audio playing via VNC.
  • We are planning to remove the audio service.

What changed

  • Remove all audio code

Test plan

  • CI passes

Rollout

Describe any procedures or requirements needed to roll this out safely (or check the box below)

  • This is fully backward and forward compatible

This is not backward compatible, so we should make a major version update for this.

@ryantm ryantm added chore Incidental change that should not impact released library major Bump major version labels May 17, 2024
@ryantm ryantm requested a review from a team as a code owner May 17, 2024 17:55
@ryantm ryantm requested review from airportyh and removed request for a team May 17, 2024 17:55
Why
===
* The audio service is not frequently used.
* The audio service is not core to Replit.
* Replit still supports audio playing via VNC.
* We are planning to remove the audio service.

What changed
===
* Remove all audio code

Test plan
===
* CI passes
@ryantm ryantm enabled auto-merge (squash) May 17, 2024 19:21
@ryantm ryantm merged commit 1067449 into master May 17, 2024
6 checks passed
@ryantm ryantm deleted the rtm-05-17-remove-audio branch May 17, 2024 19:22
@PotentialStyx
Copy link
Contributor

rip audio 🫡

PotentialStyx added a commit to Goval-Community/homeval that referenced this pull request May 18, 2024
Replit is removing the audio service soon (see: replit/replit-py#219)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Incidental change that should not impact released library major Bump major version
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants