Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: false positives when checking for node missing images #4372

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

emosbaugh
Copy link
Member

@emosbaugh emosbaugh commented Apr 12, 2023

What this PR does / why we need it:

The current functionality to list missing images uses the node object which only lists the first 50 images. This creates a false positives if an image does is not in this first 50. The new functionality added leverages the existing job code that mounts the cri socket to get a comprehensive list of images.

See an example false positive below:

Have images been loaded on node ethanm-24? (y/N) y

Node ethanm-24 missing image(s) registry.k8s.io/pause:3.6 registry.k8s.io/coredns/coredns:v1.8.6 registry.k8s.io/pause:3.5 registry.k8s.io/pause:3.6 ghcr.io/projectcontour/contour:v1.23.2 haproxy:2.7.6-alpine3.17 docker.io/flannel/flannel-cni-plugin:v1.1.2 rqlite/rqlite:7.10.0 registry:2.8.1 velero/velero-restic-restore-helper:v1.9.5 gcr.io/velero-gcp/velero-restic-restore-helper:v1.9.5 velero/velero-plugin-for-aws:v1.6.0 velero/velero-plugin-for-gcp:v1.6.0 velero/velero-plugin-for-microsoft-azure:v1.6.0

Which issue(s) this PR fixes:

Fixes NONE

Special notes for your reviewer:

Steps to reproduce

Does this PR introduce a user-facing change?

Fixes an issue that could cause kURL to erroneously prompt the user to run the load-images task when upgrading clusters that have many container images.

Does this PR require documentation?

NONE

@emosbaugh emosbaugh added type::bug Something isn't working bug::normal labels Apr 12, 2023
@emosbaugh emosbaugh requested a review from a team as a code owner April 12, 2023 18:33
@emosbaugh emosbaugh marked this pull request as draft April 12, 2023 20:26
@emosbaugh
Copy link
Member Author

There is a bootstrapping problem here. The command runs before the k8s-util image is available on the remote node.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug::normal type::bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant