Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace troubleshoot.io with troubleshoot.sh #4247

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Replace troubleshoot.io with troubleshoot.sh #4247

wants to merge 4 commits into from

Conversation

xavpaice
Copy link
Member

Relates to: replicatedhq/troubleshoot#1070

What this PR does / why we need it:

This changes references to troubleshoot.io in Support Bundle types to troubleshoot.sh. The reason for this is that the Troubleshoot project does not own troubleshoot.io.

Which issue(s) this PR fixes:

Fixes Troubleshoot #1070

Special notes for your reviewer:

Note that this changes the label stored on secrets that contain support bundles. This should be reviewed alongside replicatedhq/troubleshoot#1075

Steps to reproduce

Does this PR introduce a user-facing change?

Support-bundle specs stored in-cluster prior to this change were stored with a label `"troubleshoot.io/kind=support-bundle"`.  The label was used as a default setting for the Troubleshoot command to search for support bundles.  As of release 0.60.0, Troubleshoot searches for `"troubleshoot.sh/kind=support-bundle"`.  The label has been updated in this change to match the new search value.

Does this PR require documentation?

NONE

@xavpaice xavpaice requested a review from a team as a code owner March 24, 2023 03:41
@xavpaice xavpaice added type::bug Something isn't working bug::normal labels Mar 24, 2023
@xavpaice xavpaice mentioned this pull request Mar 24, 2023
Closed
@github-actions
Copy link
Contributor

Testgrid Run(s) Executing @ https://testgrid.kurl.sh/run/pr-4247-5b3cd6f-flannel-0.21.2-k8s-ctrd-2023-03-24T03:42:25Z

@github-actions
Copy link
Contributor

Testgrid Run(s) Executing @ https://testgrid.kurl.sh/run/pr-4247-5b3cd6f-flannel-0.20.2-k8s-ctrd-2023-03-24T03:42:25Z

@github-actions
Copy link
Contributor

Testgrid Run(s) Executing @ https://testgrid.kurl.sh/run/pr-4247-5b3cd6f-flannel-0.21.3-k8s-ctrd-2023-03-24T03:42:26Z

@github-actions
Copy link
Contributor

Testgrid Run(s) Executing @ https://testgrid.kurl.sh/run/pr-4247-5b3cd6f-flannel-0.21.0-k8s-ctrd-2023-03-24T03:42:26Z

@github-actions
Copy link
Contributor

Testgrid Run(s) Executing @ https://testgrid.kurl.sh/run/pr-4247-5b3cd6f-flannel-0.21.1-k8s-ctrd-2023-03-24T03:42:30Z

@github-actions
Copy link
Contributor

Testgrid Run(s) Executing @ https://testgrid.kurl.sh/run/pr-4247-5b3cd6f-flannel-0.20.1-k8s-ctrd-2023-03-24T03:43:19Z

@github-actions
Copy link
Contributor

Testgrid Run(s) Executing @ https://testgrid.kurl.sh/run/pr-4247-5b3cd6f-flannel-0.20.0-k8s-ctrd-2023-03-24T03:43:33Z

banjoh
banjoh reviewed Mar 24, 2023
View reviewed changes
Copy link
Member

@banjoh banjoh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is going to be a tricky upgrade. What happens if an older installer is used, say a versioned one such as https://kurl.sh/version/v2023.03.21-0/latest? The installer points to bundled support-bundle and preflight binaries that end up installed as kubectl plugins.

Making this changes would mean discovery using older troubleshoot binaries will seize to work.

@banjoh
Copy link
Member

banjoh commented Mar 24, 2023

This is going to be a tricky upgrade. What happens if an older installer is used, say a versioned one such as https://kurl.sh/version/v2023.03.21-0/latest? The installer points to bundled support-bundle and preflight binaries that end up installed as kubectl plugins.

Making this changes would mean discovery using older troubleshoot binaries will seize to work.

My suggestion is we have both labels in the spec until we are confident that there are no specs out there with the old label i.e deprecate, but not remove

@DexterYan DexterYan mentioned this pull request Apr 4, 2023
Merged
6 tasks
@xavpaice
Replace troubleshoot.io with troubleshoot.sh
887b2ba 
Adds new 'troubleshoot.sh' label to flannel troubleshoot specs,
note that the old 'troubleshoot.io' label is maintained for
backward compatibility.
@xavpaice
Copy link
Member Author

I've updated the change to preserve the existing labels, and add a new one

@github-actions
Copy link
Contributor

Testgrid Run(s) Executing @ https://testgrid.kurl.sh/run/pr-4247-0a37283-flannel-0.21.2-k8s-ctrd-2023-04-12T05:59:04Z

@github-actions
Copy link
Contributor

Testgrid Run(s) Executing @ https://testgrid.kurl.sh/run/pr-4247-0a37283-flannel-0.21.3-k8s-ctrd-2023-04-12T05:59:05Z

@github-actions
Copy link
Contributor

Testgrid Run(s) Executing @ https://testgrid.kurl.sh/run/pr-4247-0a37283-flannel-0.21.1-k8s-ctrd-2023-04-12T05:59:12Z

@github-actions
Copy link
Contributor

Testgrid Run(s) Executing @ https://testgrid.kurl.sh/run/pr-4247-0a37283-flannel-0.21.0-k8s-ctrd-2023-04-12T05:59:11Z

@github-actions
Copy link
Contributor

Testgrid Run(s) Executing @ https://testgrid.kurl.sh/run/pr-4247-0a37283-flannel-0.21.4-k8s-ctrd-2023-04-12T05:59:13Z

@github-actions
Copy link
Contributor

Testgrid Run(s) Executing @ https://testgrid.kurl.sh/run/pr-4247-0a37283-flannel-0.20.1-k8s-ctrd-2023-04-12T05:59:54Z

@github-actions
Copy link
Contributor

Testgrid Run(s) Executing @ https://testgrid.kurl.sh/run/pr-4247-0a37283-flannel-0.20.2-k8s-ctrd-2023-04-12T05:59:57Z

@github-actions
Copy link
Contributor

Testgrid Run(s) Executing @ https://testgrid.kurl.sh/run/pr-4247-0a37283-flannel-0.20.0-k8s-ctrd-2023-04-12T06:00:00Z

@xavpaice xavpaice requested a review from banjoh April 12, 2023 06:00
@github-actions
Copy link
Contributor

Testgrid Run(s) Executing @ https://testgrid.kurl.sh/run/pr-4247-bbf286c-flannel-0.21.3-k8s-ctrd-2023-06-12T02:17:35Z

@github-actions
Copy link
Contributor

Testgrid Run(s) Executing @ https://testgrid.kurl.sh/run/pr-4247-bbf286c-flannel-0.21.0-k8s-ctrd-2023-06-12T02:17:39Z

@github-actions
Copy link
Contributor

Testgrid Run(s) Executing @ https://testgrid.kurl.sh/run/pr-4247-bbf286c-flannel-0.21.2-k8s-ctrd-2023-06-12T02:17:40Z

@github-actions
Copy link
Contributor

Testgrid Run(s) Executing @ https://testgrid.kurl.sh/run/pr-4247-bbf286c-flannel-0.21.4-k8s-ctrd-2023-06-12T02:17:44Z

@github-actions
Copy link
Contributor

Testgrid Run(s) Executing @ https://testgrid.kurl.sh/run/pr-4247-bbf286c-flannel-0.21.1-k8s-ctrd-2023-06-12T02:17:50Z

@github-actions
Copy link
Contributor

Testgrid Run(s) Executing @ https://testgrid.kurl.sh/run/pr-4247-bbf286c-flannel-0.20.2-k8s-ctrd-2023-06-12T02:18:33Z

@github-actions
Copy link
Contributor

Testgrid Run(s) Executing @ https://testgrid.kurl.sh/run/pr-4247-bbf286c-flannel-0.20.1-k8s-ctrd-2023-06-12T02:18:34Z

@github-actions
Copy link
Contributor

Testgrid Run(s) Executing @ https://testgrid.kurl.sh/run/pr-4247-bbf286c-flannel-0.20.0-k8s-ctrd-2023-06-12T02:18:37Z

@github-actions
Copy link
Contributor

Testgrid Run(s) Executing @ https://testgrid.kurl.sh/run/pr-4247-4ea88ad-flannel-0.21.3-k8s-ctrd-2023-06-12T02:53:09Z

@github-actions
Copy link
Contributor

Testgrid Run(s) Executing @ https://testgrid.kurl.sh/run/pr-4247-4ea88ad-flannel-0.21.4-k8s-ctrd-2023-06-12T02:53:10Z

@github-actions
Copy link
Contributor

Testgrid Run(s) Executing @ https://testgrid.kurl.sh/run/pr-4247-4ea88ad-flannel-0.21.5-k8s-ctrd-2023-06-12T02:53:17Z

@github-actions
Copy link
Contributor

Testgrid Run(s) Executing @ https://testgrid.kurl.sh/run/pr-4247-4ea88ad-flannel-0.21.2-k8s-ctrd-2023-06-12T02:53:20Z

@github-actions
Copy link
Contributor

Testgrid Run(s) Executing @ https://testgrid.kurl.sh/run/pr-4247-4ea88ad-flannel-0.22.0-k8s-ctrd-2023-06-12T02:53:22Z

@github-actions
Copy link
Contributor

Testgrid Run(s) Executing @ https://testgrid.kurl.sh/run/pr-4247-3ce3b25-flannel-0.21.2-k8s-ctrd-2023-06-12T02:54:58Z

@github-actions
Copy link
Contributor

Testgrid Run(s) Executing @ https://testgrid.kurl.sh/run/pr-4247-3ce3b25-flannel-0.21.3-k8s-ctrd-2023-06-12T02:55:07Z

@github-actions
Copy link
Contributor

Testgrid Run(s) Executing @ https://testgrid.kurl.sh/run/pr-4247-3ce3b25-flannel-0.21.4-k8s-ctrd-2023-06-12T02:55:05Z

@github-actions
Copy link
Contributor

Testgrid Run(s) Executing @ https://testgrid.kurl.sh/run/pr-4247-3ce3b25-flannel-0.22.0-k8s-ctrd-2023-06-12T02:55:09Z

@github-actions
Copy link
Contributor

Testgrid Run(s) Executing @ https://testgrid.kurl.sh/run/pr-4247-3ce3b25-flannel-0.21.5-k8s-ctrd-2023-06-12T02:55:18Z

@github-actions
Copy link
Contributor

Testgrid Run(s) Executing @ https://testgrid.kurl.sh/run/pr-4247-3ce3b25-flannel-0.21.0-k8s-ctrd-2023-06-12T02:55:57Z

@github-actions
Copy link
Contributor

Testgrid Run(s) Executing @ https://testgrid.kurl.sh/run/pr-4247-3ce3b25-flannel-0.20.2-k8s-ctrd-2023-06-12T02:55:58Z

@github-actions
Copy link
Contributor

Testgrid Run(s) Executing @ https://testgrid.kurl.sh/run/pr-4247-3ce3b25-flannel-0.21.1-k8s-ctrd-2023-06-12T02:55:58Z

@github-actions
Copy link
Contributor

Testgrid Run(s) Executing @ https://testgrid.kurl.sh/run/pr-4247-3ce3b25-flannel-0.20.0-k8s-ctrd-2023-06-12T02:56:05Z

@github-actions
Copy link
Contributor

Testgrid Run(s) Executing @ https://testgrid.kurl.sh/run/pr-4247-3ce3b25-flannel-0.20.1-k8s-ctrd-2023-06-12T02:56:05Z

@xavpaice
Copy link
Member Author

replicatedhq/troubleshoot#1203 added the default support for the 'old' label as well as the corrected one, this PR is now safe to add to kURL.

@xavpaice xavpaice mentioned this pull request Jun 12, 2023
Open
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@camilamacedo86 camilamacedo86 camilamacedo86 left review comments

@banjoh banjoh Awaiting requested review from banjoh

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
bug::normal type::bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

default in-cluster label references a domain that is not registered
3 participants
@xavpaice @banjoh @camilamacedo86