Feat/tgrun default overrides #1037
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DanStough
force-pushed
the
feat/tgrun-default-overrides
branch
5 times, most recently
from
24bc929
to
87a5c63
Compare
emosbaugh
reviewed
Jan 19, 2021
| var kurlPlans []types.Instance | ||
|
|
||
| // Custom Kurl Spec takes precedence | ||
| if schedulerOptions.Spec != "" { |
There was a problem hiding this comment.
is tgapi open? last time i checked i think it was. i worry that this is a security issue as it may open us up to arbitrary specs being run. right now we dont have anything like addon script or helm but if we did wouldnt this be an issue? @laverya wanna weigh in here?
emosbaugh
approved these changes
Jan 19, 2021
DanStough
force-pushed
the
feat/tgrun-default-overrides
branch
from
87a5c63
to
aa22e3e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pivoted a little from the original plan to use CLI flags for everything to just using a
--specflag at the CLI per @emosbaugh's suggestion. If you want to test thetgrunchanges:When this gets merged I have a PR for metrics-server that I will make to test out the action.
Lessons learned: