-
Notifications
You must be signed in to change notification settings - Fork 93
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
default in-cluster label references a domain that is not registered #1070
default in-cluster label references a domain that is not registered #1070
Comments
It hasn't been out that long, we're only talking about a default (IE someone can set this on the command line), we should just make the correction to the typo and not spend weeks worrying about if we should fix it. The release notes should have a clear indicator that there was a bug and fixing it changed the default label. |
A lot of discussion in PRs has indicated that this label is 'out there' in the wild, and we can't just go changing it will we figure out a deprecation approach. Suggestion:
|
The following command expects BOTH labels to be on the secret, rather than either one. That's what we need to resolve, before changing the default:
|
Partial-fix: #1070 Changes the default label for preflights to troubleshoot.sh/kind: preflight
replicatedhq/helm-charts#97 is related |
Partial-fix: #1070 Changes the default label for preflights to troubleshoot.sh/kind: preflight
Bug Description
The default label we use to search for secrets and configMaps containing Troubleshoot specs in a cluster ("troubleshoot.io/kind=support-bundle") refers to a domain "troubleshoot.io" which is not registered.
Expected Behavior
The label should reference "troubleshoot.sh" which is registered for the Troubleshoot project.
Steps To Reproduce
n/a
Additional Context
Changes required:
The text was updated successfully, but these errors were encountered: