Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

default in-cluster label references a domain that is not registered #1070

Open
3 of 5 tasks
xavpaice opened this issue Mar 23, 2023 · 4 comments · Fixed by #1203 or #1204 · May be fixed by replicatedhq/kURL#4247
Open
3 of 5 tasks

default in-cluster label references a domain that is not registered #1070

xavpaice opened this issue Mar 23, 2023 · 4 comments · Fixed by #1203 or #1204 · May be fixed by replicatedhq/kURL#4247

Comments

@xavpaice
Copy link
Member

xavpaice commented Mar 23, 2023

Bug Description

The default label we use to search for secrets and configMaps containing Troubleshoot specs in a cluster ("troubleshoot.io/kind=support-bundle") refers to a domain "troubleshoot.io" which is not registered.

Expected Behavior

The label should reference "troubleshoot.sh" which is registered for the Troubleshoot project.

Steps To Reproduce

n/a

Additional Context

Changes required:

@chris-sanders
Copy link
Member

It hasn't been out that long, we're only talking about a default (IE someone can set this on the command line), we should just make the correction to the typo and not spend weeks worrying about if we should fix it. The release notes should have a clear indicator that there was a bug and fixing it changed the default label.

@xavpaice
Copy link
Member Author

xavpaice commented Jun 1, 2023

A lot of discussion in PRs has indicated that this label is 'out there' in the wild, and we can't just go changing it will we figure out a deprecation approach.

Suggestion:

  • Make Troubleshoot able to read multiple labels with the one switch, i.e have --selector "troubleshoot.io/kind=support-bundle,troubleshoot.sh/kind=support-bundle" a valid setting
  • Make that the default for Troubleshoot
  • Then change the docs, KOTS and kURL to use the new label.

@xavpaice
Copy link
Member Author

xavpaice commented Jun 1, 2023

The following command expects BOTH labels to be on the secret, rather than either one. That's what we need to resolve, before changing the default:

support-bundle --load-cluster-specs --debug --selector "troubleshoot.io/kind=support-bundle,troubleshoot.sh/kind=support-bundle"

@xavpaice xavpaice assigned xavpaice and DexterYan and unassigned xavpaice Jun 2, 2023
xavpaice added a commit that referenced this issue Jun 2, 2023
Partial-fix: #1070

Changes the default label for preflights to troubleshoot.sh/kind: preflight
@xavpaice
Copy link
Member Author

xavpaice commented Jun 2, 2023

replicatedhq/helm-charts#97 is related

xavpaice added a commit that referenced this issue Jun 5, 2023
Partial-fix: #1070

Changes the default label for preflights to troubleshoot.sh/kind: preflight
@xavpaice xavpaice reopened this Jun 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment