Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): update dependency eslint to v6.7.1 #4896

Merged
merged 4 commits into from Dec 2, 2019
Merged

Conversation

renovate[bot]
Copy link
Contributor

@renovate renovate bot commented Nov 28, 2019

This PR contains the following updates:

Package Update Type Change Sourcegraph
eslint (source) minor devDependencies 6.6.0 -> 6.7.1 code search for "eslint"

Release Notes

eslint/eslint

v6.7.1

Compare Source

  • dd1e9f4 Fix: revert changes to key-spacing due to regression (#​12598) (Kai Cataldo)
  • c644b54 Docs: Update README team and sponsors (ESLint Jenkins)

v6.7.0

Compare Source


Renovate configuration

📅 Schedule: At any time (no schedule defined).

🚦 Automerge: Enabled.

♻️ Rebasing: Whenever PR is stale, or if you modify the PR title to begin with "rebase!".

🔕 Ignore: Close this PR and you won't be reminded about this update again.


  • If you want to rebase/retry this PR, check this box

Newsflash: Renovate has joined WhiteSource, and is now free for all use. Learn more or view updated terms and privacy policies.

@renovate renovate bot added the ready label Nov 28, 2019
renovate-approve[bot]
renovate-approve bot previously approved these changes Nov 28, 2019
renovate-approve[bot]
renovate-approve bot previously approved these changes Nov 28, 2019
@viceice
Copy link
Member

viceice commented Nov 28, 2019

image
needs a lint fix

@viceice
Copy link
Member

viceice commented Nov 28, 2019

@rarkins airbnb rule is forcing 'no-cond-assign': ["error", "always"], override with: 'no-cond-assign': ["error", "except-parens"] ?

@viceice
Copy link
Member

viceice commented Nov 28, 2019

found the causing change: eslint/eslint#12465

Will push a fix to this branch

@viceice viceice self-assigned this Nov 28, 2019
@renovate
Copy link
Contributor Author

renovate bot commented Nov 28, 2019

PR has been edited

👷 This PR has received other commits, so Renovate will stop updating it to avoid conflicts or other problems. If you wish to abandon your changes and have Renovate start over you may click the "rebase" checkbox in the PR body/description.

@viceice
Copy link
Member

viceice commented Nov 28, 2019

@rarkins How to rerequest review from bot?

@viceice viceice requested a review from rarkins November 29, 2019 08:26
@rarkins rarkins merged commit e6200d5 into master Dec 2, 2019
@rarkins rarkins deleted the renovate/linters branch December 2, 2019 13:03
@renovate-release
Copy link
Collaborator

🎉 This PR is included in version 19.72.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 16, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants