feat(workers/repository): Update package files in the same order they're extracted #28671
+137
−29
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
For some managers that can have dependencies between input files (pip-compile, for example) it's important to update each input file in the correct order. This changes getUpdatedPackageFiles to sort its lists of package files into the same order that they were returned by the manager's extract function.
Since package files can be referenced by multiple managers and since each manager could return the package files in a different order I also inverted the update logic from
to
This lets us sort the list of package files only once per manager.
Context
#28518
Documentation (please check one with an [x])
How I've tested my work (please select one)
I have verified these changes via: