Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: use import() to enable update of p-map #11147

Closed
wants to merge 3 commits into from
Closed

refactor: use import() to enable update of p-map #11147

wants to merge 3 commits into from

Commits on Aug 7, 2021

  1. Use import() to enable update of p-map

    @voxpelli
    voxpelli committed Aug 7, 2021
    Configuration menu
    Copy the full SHA
    8bee6e7 View commit details
    Browse the repository at this point in the history

  2. Workaround for TypeScripts compiling of import() 

    Have the dynamic import() happen in an uncompiled dependency instead, that way TypeScript can't convert the import() to a require() and thus it will work with ESM modules in TS as well.

Relevant TypeScript issue: microsoft/TypeScript#43329
    @voxpelli
    voxpelli committed Aug 7, 2021
    Configuration menu
    Copy the full SHA
    d3d5d8e View commit details
    Browse the repository at this point in the history

  3. Missing files...

    @voxpelli
    voxpelli committed Aug 7, 2021
    Configuration menu
    Copy the full SHA
    de300b8 View commit details
    Browse the repository at this point in the history