-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(config): improve monorepo names #10243
feat(config): improve monorepo names #10243
Conversation
Unsure if I need to add the Feel free to remove the |
Can you check what semantic-release supports? |
This comment has been minimized.
This comment has been minimized.
Quote from semantic-release/semantic-release#1796 (comment):
Also there's this from
I think the only thing |
this is true because we still use the angular convention by default today. we intend to switch that default to conventional commits in the future, and that change can be tracked here. until then, you could change your convention preset, if you'd like. |
It seems we're already using the conventional commit preset from Line 32 in 03a04de
Link to file on current What do you think @travi? Would it be safe to use a PR title like this: I'll keep things as they are until we know for sure how we've configured |
assuming you are mentioning the PR title because the PR will be squashed (and since the PR title is used as the default commit message when squashing), i would expect that to result in being treated as a breaking change, as you expect. it is important to keep in mind that |
All our PRs get squashed into one commit, with commits from the PR branch going in the commit body, and the PR title as commit message.
Cool!
Will do! |
@rarkins I've left some comments in the code, can you maybe review the PR and tell me what you think? |
Summary: I'm bad at dealing with merge conflicts, and need a way to avoid them on this PR. 😉 I'm having trouble fixing the merge conflict(s) on this PR every time I merge the current The basic problem:
I'm bad at dealing with merge conflicts, and rather avoid them completely. 🙈 I think the root cause is that I'm trying to keep up-to-date with a branch that's moving under me. Which will always end badly... 😄 I think we have the following options to get out of this mess:
Or maybe one of you has a great idea? I'm open to suggestions! 😄 |
Co-authored-by: Rhys Arkins <rhys@arkins.net>
Co-authored-by: Rhys Arkins <rhys@arkins.net>
@rarkins maybe this should go in the |
@HonkingGoose I'll merge it into v26 if you're happy with it |
Not sure if there is a pending release for this, but it's breaking updates in v26.1.2 |
@tomkerkhove we put these changes into a Can you provide more details on how things are going wrong in Pinging @rarkins to listen to this conversation as well. |
The app is not yet updated to v26. @tomkerkhove can you provide more details? |
We are getting the following:
Where we had to change this in our config: "config:base",
":gitSignOff",
"group:azure azure-libraries-for-netMonorepo",
"group:azure azure-sdk-for-netMonorepo",
"group:azure azure-storage-netMonorepo",
- "group:swashbuckle-aspnetcoreMonorepo"
+ "group:SwashbuckleMonorepo"
] Same for ASP.NET Extensions:
Note that these are written as INFO so our pipeline passes, while Renovate couldn't do anything This is OK btw, just want to make sure you are aware of it. (this is a self-hosted scenario) |
We put it in a major release intentionally, although I guess we failed to declare it as breaking: @viceice @HonkingGoose I think we should add migration code to migrate all the old names to new names automatically. Otherwise we might see a lot of this suddenly in the app once it goes live |
That would be nice to have indeed, thank you for that! But you are correct - We just use the latest version so this is OK but just wanted to let you know in case you were not aware of it. Maybe the error can have a link to the notes or so? |
Definitely thank you for reporting it as I wasn't aware yet. I think best we do automigration internally so that others like you don't even need to think about it. |
Thanks a ton! |
Yes. 🤦♂️ |
Changes:
Context:
Found a lot of inconsistencies, so I'm labeling this a breaking change. 😄
Some repos have moved, some have deprecation notices in them, one is even outright gone.
Closes #10210.
Documentation (please check one with an [x])
How I've tested my work (please tick one)
I have verified these changes via: