Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: migrate to jest v27 #10160

Merged
merged 4 commits into from
May 28, 2021
Merged

chore: migrate to jest v27 #10160

merged 4 commits into from
May 28, 2021

Conversation

viceice
Copy link
Member

@viceice viceice commented May 26, 2021

Changes:

Migrates to Jest v27

Context:

closes #10159

Documentation (please check one with an [x])

  • I have updated the documentation, or
  • No documentation update is required

How I've tested my work (please tick one)

I have verified these changes via:

  • Code inspection only, or
  • Newly added unit tests, or
  • No new tests but ran on a real repository, or
  • Both unit tests + ran on a real repository

@viceice viceice mentioned this pull request May 26, 2021
6 tasks
@HonkingGoose

This comment has been minimized.

@HonkingGoose
Copy link
Collaborator

@viceice does your commit fixing the memory leak maybe also fix issue #5647?

@viceice
Copy link
Member Author

viceice commented May 26, 2021

@viceice I was thinking if we could switch to a lighter weight node environment? Maybe we don't need a full JSDOM environment? We might be able to speed up the tests even more... 😄

If it turns out we still need the full fat JSDOM environment for some tests, we could use docblocks comment to mark the parts of the tests that can run in the node environment. That way we could use the lightweight env where possible, and use the full fat env where needed.

Link to Jest blog post: https://jestjs.io/blog/2021/05/25/jest-27 search for the string Running tests in a JSDOM environment to see what Jest has to say about this.

We already use node env 😏

testEnvironment: 'node',

@HonkingGoose
Copy link
Collaborator

We already use node env 😏

That was a quick fix! 🤣

@viceice
Copy link
Member Author

viceice commented May 26, 2021

@viceice does your commit fixing the memory leak maybe also fix issue #5647?

Nope, i can see it when not running with --logHeapUsage 😕

@viceice viceice marked this pull request as ready for review May 27, 2021 14:53
@viceice viceice requested a review from rarkins May 27, 2021 14:53
@viceice
Copy link
Member Author

viceice commented May 27, 2021

I think this is ready

@rarkins rarkins merged commit db98baa into main May 28, 2021
@rarkins rarkins deleted the feat/jest-v27 branch May 28, 2021 07:41
@renovate-release
Copy link
Collaborator

🎉 This PR is included in version 25.31.12 🎉

The release is available on:

Your semantic-release bot 📦🚀

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 28, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Migrate Jest to v27
4 participants