Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Multiple bumps & fixes to CI versions (Kubernetes, GH Actions, PHP) #380

Open
wants to merge 8 commits into
base: master
Choose a base branch
from
Open

Multiple bumps & fixes to CI versions (Kubernetes, GH Actions, PHP) #380

wants to merge 8 commits into from
+33 −17

Conversation

cuppett
Copy link
Contributor

@cuppett cuppett commented Aug 31, 2023 •
edited

Multiple versions being tested now out of support as well as a few fixes:

  1. Caching of composer dependencies wasn't working, fixed
  2. Bumped minikube to the current latest
  3. Updated to the most recent 3 kubernetes versions
  4. Fixed an issue observed once where minikube picked the podman engine (and it didn't work for CNI). Explicitly setting docker to avoid that flake in the future.
  5. Added PHP 8.3

Note: 1.25 & 1.26 also works and passes tests, but it would add more versions and there's a couple spots in the project and docs that say "latest 3", so I left that off the back.

@cuppett cuppett force-pushed the master branch 2 times, most recently from 2d461f9 to d5773a3 Compare August 31, 2023 11:00
@codecov
Copy link

codecov bot commented Aug 31, 2023 •
edited

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.68%. Comparing base (5d9d356) to head (a7980e3).

Additional details and impacted files 
@@             Coverage Diff              @@
##             master     #380      +/-   ##
============================================
+ Coverage     94.17%   94.68%   +0.51%     
  Complexity      700      700              
============================================
  Files            70       70              
  Lines          1837     1788      -49     
============================================
- Hits           1730     1693      -37     
+ Misses          107       95      -12

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@cuppett cuppett mentioned this pull request Aug 31, 2023
Open
@stale stale bot added the wontfix This will not be worked on label Oct 15, 2023
@stale stale bot removed the wontfix This will not be worked on label Dec 2, 2023
@cuppett
Copy link
Contributor Author

cuppett commented Dec 2, 2023 •
edited

Added a few more commits to fix minor issues, bring in some of the dependabot changes and add PHP 8.3.

Summary:

  • Removes deprecated vierbergenlars/php-semver in favor of composer/semver (adds testcase)
  • Adds PHP 8.3
  • Updates Kubernetes versions from 1.24, 1.25, 1.26 to 1.26, 1.27, 1.28
  • CI version updates to actions/checkout, actions/cache, minikube
  • Some minor style corrections to try and help those bots a bit

@cuppett cuppett force-pushed the master branch 4 times, most recently from 02c021a to 89a2a13 Compare December 2, 2023 12:52
@cuppett
Copy link
Contributor Author

cuppett commented Dec 2, 2023

@rennokki These tests are coming back clean. Revisiting this, I bumped a few other versions and dependencies. Added PHP 8.3, you may want to drop 8.1 since we had 8.0 dropped during this phase of the lifecycle.

@cuppett cuppett mentioned this pull request Feb 28, 2024
Merged
@cuppett
Copy link
Contributor Author

cuppett commented Feb 28, 2024

@rennokki Anything else needed to merge this one? I'm happy to make any other adjustments to get this one in.

cuppett and others added 7 commits April 10, 2024 19:59
@cuppett
Bump minikube to 1.32
579dfcf
@cuppett
Fix: Explicitly set docker driver
185da25 
(Noticed a GH action once chose podman and failed/flaked there.)
@cuppett
Fix: Cache key with wildcard never hits
44c65d9 
Noticing the cache isn't hitting when action runs.
Remove hardcoded composer cache directory.
Remove wildcard .* in Laravel version as part of cache key.
Bump actions/cache to 3.3.1 (via @V3).
@cuppett
Bumps for Kubernetes 1.27, 1.28, 1.29
c61f0d2
@dependabot @cuppett
Bump actions/checkout from 3 to 4
a33394d 
Bumps [actions/checkout](https://github.com/actions/checkout) from 3 to 4.
- [Release notes](https://github.com/actions/checkout/releases)
- [Changelog](https://github.com/actions/checkout/blob/main/CHANGELOG.md)
- [Commits](actions/checkout@v3...v4)

---
updated-dependencies:
- dependency-name: actions/checkout
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>
@cuppett
Node.js 16 actions are deprecated.
096256e 
Please update the following actions to use Node.js 20: actions/cache@v3, codecov/codecov-action@v3.1.0.

For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
@cuppett
Bump to PHP 8.3
edd53e0
@cuppett cuppett changed the title Multiple bumps, fixes and remove deprecated vierbergenlars/php-semver Multiple bumps & fixes to CI versions (Kubernetes, GH Actions, PHP) Apr 11, 2024
@cuppett
Copy link
Contributor Author

cuppett commented Apr 11, 2024

@rennokki I cleaned this up for easier review squashing like for like PRs that stretched over time. Also, removed the overlap with the deprecated package PR. This has just version bumps in the ci.yml file to current versions of kubernetes, laravel, PHP and GH actions. All checks clean.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@cuppett