Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add support for SIGINT on Windows (fixes issue #1720) #1853

Merged
merged 5 commits into from Jun 24, 2021

Commits on Apr 11, 2021

  1. fix: add download and extraction of windows-kill.exe v1.1.4 (remy#1720)

    This commit adds an install script that runs on 'npm install'. Its
    purpose is to download, extract and verify a specific version of
    the windows-kill.exe binary.
    
    I decided not add the - windows only - executable directly to this
    project to keep the dependencies clear. Furthermore I did not use
    the node-window-kill package, because it comes with node-gyp which
    requires python and vs2017 build tools on the target machine.
    countzero committed Apr 11, 2021
    Copy the full SHA
    6c4b16b View commit details
    Browse the repository at this point in the history
  2. fix: change child process termination for windows contexts (remy#1720)

    This commit replaces the taskkill invocation with windows-kill.exe.
    
    We are now sending a SIGINT POSIX signal to the node process in a
    Windows context.
    
    Known issues: The windows-kill.exe has to be triggered in a detached
    process context, which currently flashes a terminal window on each
    reload. Furthermore the 'restart' event is triggered twice on the bus.
    countzero committed Apr 11, 2021
    Copy the full SHA
    ee99a83 View commit details
    Browse the repository at this point in the history

Commits on Apr 12, 2021

  1. fix: optimize windows-kill execution and silence wmic errors (remy#1720)

    This commit silences all errors from the wmic.exe process. Which is save,
    because the error case is handled by falling back to the child.pid.
    
    It also optimizes the windows-kill invocation by minimizing (hiding)
    the terminal window and keeping it open until the process has finished.
    countzero committed Apr 12, 2021
    Copy the full SHA
    1424afc View commit details
    Browse the repository at this point in the history

Commits on Apr 29, 2021

  1. fix: replace provisioning script with the raw windows-kill.exe (remy#…

    …1720)
    
    This commit replaces the provisioning script, which downloaded
    a specific windows-kill.exe binary, with the binary itself.
    We are using the x64 version of the windows-kill.exe from:
    https://github.com/ElyDotDev/windows-kill/releases/tag/1.1.4
    
    We are now embedding the binary with the project directly to
    decrease the complexity and avoid breaking the build by external
    changes. Actually the maintainer of windows-kill changed his
    GitHub username recently from "alirdn" to "ElyDotDev" which
    broke the provisioning script!
    countzero committed Apr 29, 2021
    Copy the full SHA
    50aee8d View commit details
    Browse the repository at this point in the history

Commits on May 9, 2021

  1. fix: add support for hard shutdown on SIGKILL (remy#1720)

    This commit adds back the hard shutdown behaviour under Windows
    as an opt-in: If the --signal option is "SIGKILL" nodemon will
    terminate the process group by force without waiting for the
    process to clean-up. This matches a SIGKILL on a UNIX system.
    countzero committed May 9, 2021
    Copy the full SHA
    f7c6e0d View commit details
    Browse the repository at this point in the history