Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: package.main with -- arguments #1773

Merged
merged 3 commits into from Oct 4, 2020
Merged

fix: package.main with -- arguments #1773

merged 3 commits into from Oct 4, 2020

Commits on Oct 4, 2020

  1. fix: package.main with -- arguments 

    Fixes #1758

The combination of using a package.main (which sets the script
position to index zero) and using the -- stop slurp meant that
the arguments had the script appended to the end instead of
prepended to the start. The net result meant that when the script
was forked, it would drop the first user arg.

See diff for details of the fix - a simple check against null.
    @remy
    remy committed Oct 4, 2020
    Copy the full SHA
    bc66354 View commit details
    Browse the repository at this point in the history

  2. chore: merge main

    @remy
    remy committed Oct 4, 2020
    Copy the full SHA
    dbb927a View commit details
    Browse the repository at this point in the history

  3. fix: protect against missing opts

    @remy
    remy committed Oct 4, 2020
    Copy the full SHA
    90634f6 View commit details
    Browse the repository at this point in the history