Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: runOnChangeOnly=true #1751

Merged
merged 3 commits into from Oct 4, 2020
Merged

fix: runOnChangeOnly=true #1751

merged 3 commits into from Oct 4, 2020

Commits on Aug 7, 2020

  1. fix: test case runOnChangeOnly true 

    Fixed the problem in lib/monitor/run and made this test to run.
Script will create a tmp file, which should not happen as  runOnChangeOnly is set to true.
    @MonarchChakri
    MonarchChakri committed Aug 7, 2020
    Copy the full SHA
    e3717eb View commit details
    Browse the repository at this point in the history

  2. fix: corrected remy#1742 

    Moved run.kill outside the run function
Moved up restart bind, before runCmd so that we can use it in run.kill

If command is not to be run the we just need to watch files and not fork/spawn a child process

Binding options with instance of run, so that we can use it in run.kill (https://travis-ci.org/github/remy/nodemon/builds/714612398)
Updated run options inside if condition (https://travis-ci.org/github/remy/nodemon/builds/714620936)
    @MonarchChakri
    MonarchChakri committed Aug 7, 2020
    Copy the full SHA
    6dade3c View commit details
    Browse the repository at this point in the history

  3. fix: Added a precheck 

    This ensures that config.options.execOptions exists before accessing script (https://travis-ci.org/github/remy/nodemon/builds/714622542)
    @MonarchChakri
    MonarchChakri committed Aug 7, 2020
    Copy the full SHA
    e0f827a View commit details
    Browse the repository at this point in the history